Project

General

Profile

Actions
Copy link

Feature #10739

closed

merge upstream of json-1.8.2

Added by hsbt (Hiroshi SHIBATA) over 10 years ago. Updated over 10 years ago.

Status:
Closed
Assignee:
-
Target version:
-
[ruby-core:67564]

Description

I create patch of json-1.8.2 changes. see attached file.

json-1.8.2 implement different way of Typed_Data macro.
we need to apply upstream changes into ruby-core, or backport request to json gem.

nobu, nalsh: how do you think this patch?

PS. this patch is create from https://github.com/flori/json/pull/234 and upstream master.

Files

json-1.8.2.patch (6.17 KB) json-1.8.2.patch hsbt (Hiroshi SHIBATA), 01/13/2015 12:13 PM
Actions
Copy link
 #1 [ruby-core:67565]

Updated by nobu (Nobuyoshi Nakada) over 10 years ago

GET_STATE_TO macro seems no longer necessary.

Actions
Copy link
 #2 [ruby-core:67567]

Updated by zzak (zzak _) over 10 years ago

  • Status changed from Open to Feedback

I think we need to fix the regression in gem before we merge to trunk.

We can take advantage of gem's CI for fixing regression.

Actions
Copy link
 #3 [ruby-core:67569]

Updated by hsbt (Hiroshi SHIBATA) over 10 years ago

  • Status changed from Feedback to Open
Actions
Copy link
 #4 [ruby-core:68105]

Updated by hsbt (Hiroshi SHIBATA) over 10 years ago

GET_STATE_TO is used by other function.

Actions
Copy link
 #5

Updated by hsbt (Hiroshi SHIBATA) over 10 years ago

  • Status changed from Open to Closed
  • % Done changed from 0 to 100

Applied in changeset r49582.

Actions
Copy link

Also available in: Atom PDF

Like0
Like0Like0Like0Like0Like0