Activity
From 05/20/2017 to 05/26/2017
05/26/2017
-
09:37 PM Feature #13601: Remove yield_self from Ruby 2.5 (already implemented)
- `instance_eval` changes scope, while `yield_self` does not.
```ruby
class A
def foo
1
end
def yie... -
08:33 PM Feature #13601: Remove yield_self from Ruby 2.5 (already implemented)
- Note there are differences, for example
~~~ruby
42.instance_eval { abs2 } #=> 1764
~~~
won't work with Kernel#y... -
07:35 PM Feature #13601 (Closed): Remove yield_self from Ruby 2.5 (already implemented)
- Issue https://bugs.ruby-lang.org/issues/6721 for adding `yield_self` is unnecessary as `BasicObject#instance_eval` wi...
-
09:31 PM Bug #10093: SecureRandom.uuid is not valid v4 and/or RFC 4122
- usa (Usaku NAKAMURA) wrote:
> Please do not reuse past tickets.
Open new issue https://bugs.ruby-lang.org/issues/... -
02:25 PM Bug #10093: SecureRandom.uuid is not valid v4 and/or RFC 4122
- Please do not reuse past tickets.
-
- https://www.ietf.org/rfc/rfc4122.txt (#4.4)
---
current test is https://github.com/ruby/ruby/blob/ruby_2_4/test/t... -
- https://www.ietf.org/rfc/rfc4122.txt (#4.4)
---
(reopen from https://bugs.ruby-lang.org/issues/10093#change-65105... -
08:48 PM Feature #13602 (Rejected): Optimize instance variable access if $VERBOSE is not true when compiling
- This patch optimizes instance variable lookup in the case the $VERBOSE
is not true when compiling. If $VERBOSE is n... -
06:32 PM Feature #13378: Eliminate 4 of 8 syscalls when requiring file by absolute path
- > ```diff
> -VALUE rb_find_file_safe(VALUE, int);
> +VALUE rb_find_file_safe(VALUE, int, int);
When you are CRub... -
05:11 PM Revision 015d05c6 (git): numeric.c: remove duplicate code
- * numeric.c (flo_to_i): use dbl2ival and reduce duplicate code.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@58... - 05:10 PM Revision 081b38fd (git): * 2017-05-27
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@58910 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
05:10 PM Revision 6270d595 (git): Improve Array#concat performance if only one argument is given
- * array.c (rb_ary_concat_multi): concatenate the array without generating
temporary Array object if only one argu... -
04:52 PM Feature #13600: yield_self should be chainable/composable
- In case the description is unclear, the goal is to support something like this:
```
pipeline = (&:upcase).yield_s... -
- One of the main use cases that would make `yield_self` a helpful addition is to build functional pipelines (function ...
-
02:55 PM Bug #13599 (Closed): Float#ceil(n) doesn't work for small floats
- When using ceil to round up to n digits (as opposed to nearest integer) with the optional first argument, it doesn't ...
-
02:17 PM Revision 43572889 (git): erb.rb: Tiny improvement of compiling cost
- by reducing string allocation.
* Before
app_erb 0.687
* After
app_erb 0.679
git-svn-id: svn+ssh://ci.ruby-lang.o... -
- introduced in r58905.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@58907 b2dd03c8-39d4-4d8f-98ff-823fe69b080e - 01:49 PM Revision d9efeebf (git): * properties.
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@58906 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- to skip object allocation for static string.
We can't always enable frozen_string_literal pragma because we can't
fr... -
- Does anyone have opinion about this? Can I commit this?
I think it would be good to apply this patch to improve li... -
- The original intention of introducing `_erbout.force_encoding`
in r21170 was:
- "returns a string in the same charac... -
- [Fix GH-1629]
Signed-off-by: Matt Wrock <[email protected]>
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@58903... -
07:28 AM
Bug #13595 (Closed): rb_alloc_tmp_buffer2 broken when: elsize % sizeof(VALUE) == 0
- Applied in changeset trunk|r58902.
----------
attempt to fix rb_alloc_tmp_buffer2 for ALLOCV_N
This is a confusing ... -
- Reconsidered and yours seems the intended.
-
- Maybe like this?
```diff
diff --git a/include/ruby/ruby.h b/include/ruby/ruby.h
index 0b277dce19..95dab1bf3f 100... - 07:28 AM Revision 190e29f7 (git): attempt to fix rb_alloc_tmp_buffer2 for ALLOCV_N
- This is a confusing function to my arithmetic-challenged mind,
but nobu seems alright with this. Anyways this lets m... -
- * dir.c (glob_helper): yield globbed part only without the base
directory path part if the base is given. [Feature... -
- * tool/runruby.rb: do not set environment to preload on multiarch
platforms, otherwise other external commands (e.g... -
06:42 AM Revision 10ee38b6 (git): * lib/uri/common.rb: [DOC] add rdoc to describe
- URI.unescape is obsolete [ci-skip] [fix GH-1630]
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@58899 b2dd03c8-39... -
- * sprintf.c (rb_str_format): when `t + 1 == end` (or `t < end`),
`*t == '%'` is always true. [ruby-core:80153] [Bu... -
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@58897 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- * vm_insnhelper.c (comparable_by_identity): extract the condition
where comparable by identity. currently both are... -
05:32 AM Feature #13483 (Rejected): TracePoint#enable with block for thread-local trace
-
- After consideration, I found several problems.
There is a implicit expectation that we can emulate block accept ca... -
- Applied in changeset trunk|r58895.
----------
Symbol support for opt_eq_func.
* vm_insnhelper.c (opt_eq_func): opti... -
- * vm_insnhelper.c (opt_eq_func): optimize for symbol comparison.
[Bug #13330] [fix GH-1540]
git-svn-id: svn+ssh:/... -
01:50 AM Revision 8dce6221 (git): compile.c: fix possible use of uninitialized value
- LABEL::unremovable added by r58810 is not initialized by
new_label_body(), making the optimization unstable.
git-svn...
05/25/2017
-
- * test/lib/envutil.rb: introduce EnvUtil.apply_timeout_scale to use
this scale from outside.
* test/ruby/test_thre... -
08:08 PM Bug #13595: rb_alloc_tmp_buffer2 broken when: elsize % sizeof(VALUE) == 0
- [email protected] wrote:
> Bug #13595: rb_alloc_tmp_buffer2 broken when: elsize % sizeof(VALUE) == 0
> https://... -
06:30 PM Feature #8643: Add Binding.from_hash
- Yes, it makes sense. Thanks a lot! :)
-
- Since [Feature #8631] is accepted, closing this ticket.
-
- Awesome, thanks!
-
- Applied in changeset trunk|r58891.
----------
erb.rb: Add ERB#result_with_hash
[ruby-core:55985] [Feature #8631] [f... -
- I discussed about this with Seki-san.
For name, I rethought that "result_with_locals" sounds to use caller's local... -
05:43 PM Feature #13574: Method redefinition warning
- > What do you mean?
> That remove_method + new definition is not atomic?
Yes. Using remove_method + define_method... -
09:32 AM Feature #13574: Method redefinition warning
- matthewd (Matthew Draper) wrote:
> apart from removing the method first, which isn't atomic
What do you mean?
Th... -
- See r58891.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@58892 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- [ruby-core:55985] [Feature #8631] [fix GH-1623]
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@58891 b2dd03c8-39d... -
- Applied in changeset trunk|r58890.
----------
Raise ArgumentError if sprintf format string ends with %
* Add tests ... -
- * Add tests and specs. See ruby/spec#401.
Patch by Yuta Iwama and Shintaro Morikawa.
[ruby-core:80153] [Bug #1331... - 03:14 PM Revision e779eee9 (git): * 2017-05-26
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@58889 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
03:14 PM Revision a2b4979b (git): hash.c: docs for Hash#transform_values
- * hash.c: [DOC] fix return value in call-seq of Hash#transform_values;
other small fixes.
git-svn-id: svn+ssh://ci... -
- This syntax only adds a support for comments that include "%>" or "%%>". I think the major use case of such kind of f...
-
01:35 PM Feature #13563: Implement Hash#choice method.
- babanba-n (matzbara masanao) wrote:
> I feel that Hash#slice is wrong name and Hash#pick is better name.
> If key ... -
- I've created a PR https://github.com/ruby/ruby/pull/1632 with a name String#**remove_prefix**.
I will merge if the n... -
- rb_obj_as_string() calls not #to_str (idTo_str) but #to_s (idTo_s).
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trun... -
- Optimize performance regression introduced in r56021.
* Benchmark (i7-4790K @ 4.00GH, x86_64 GNU/Linux)
Benchmark.i... -
- Closing per OP request
-
- stomar (Marcus Stollsteimer) wrote:
> I also added a NEWS entry and updated the specs with a version guard for 2.5 (... -
08:58 AM Bug #13598 (Closed): mutex_m: Missing info in the doc
- The doc for Mutex_m should remind the user of the necessity of calling super() in *each* class that includes Mutex_m....
-
- * dir.c: [DOC] document the new `base` keyword argument of Dir.glob
[Feature #13056]; also improve docs for Dir.glo... -
- * dir.c: [DOC] fix examples for Dir.each_child and Dir.children.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@5... -
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@58883 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- * vm_insnhelper.c (rb_eql_opt): should call #eql? on Float and
String, not #==.
git-svn-id: svn+ssh://ci.ruby-lang... -
- Applied in changeset trunk|r58881.
----------
Improve performance of rb_eql()
This improvement is similar with http... -
- Applied in changeset trunk|r58880.
----------
Improve performance of rb_equal()
* object.c (rb_equal): add optimize... -
- This improvement is similar with https://github.com/ruby/ruby/pull/1552
internal.h: add declaration of rb_eql_opt() ... -
- * object.c (rb_equal): add optimized path to compare the objects using
rb_equal_opt(). Previously, if not same ob... -
- Applied in changeset trunk|r58879.
----------
dir.c: Dir.each_child and Dir.children
* dir.c (dir_s_each_child, dir... -
- * dir.c (dir_s_each_child, dir_s_children): Dir.each_child and
Dir.children which are similar to Dir.foreach and Di... -
- * test/ruby/test_dir.rb (test_entries): test class singleton
method Dir.entries too.
git-svn-id: svn+ssh://ci.ruby... -
-
- * dir.c (dir_each_entries): expand entries without method calls.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@5... -
01:08 AM Bug #13594: Segfault in gc_sweep_step 2.4.1
- I've found a similar result. https://travis-ci.org/sferik/rails_admin/jobs/124039186
This issue seems to be related ...
05/24/2017
- 09:26 PM Revision 2079b710 (git): string.c: fix String#crypt leak introduced in r58866
- * string.c (rb_str_crypt): define LARGE_CRYPT_DATA when allocating
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk... -
07:40 PM
Misc #12529: LEGAL file covering all the license information within Ruby
- @hsbt I do not have any other considerations or concerns right now.
-
06:15 PM Misc #12529: LEGAL file covering all the license information within Ruby
- I think this issue is already resolved without UCD license.
@jaruga
Is there another consideration about LEGAL ... -
- [email protected] wrote:
> Hello
>
> I've observed that a lot of memory gets allocated and wasted
> when `read_n... -
05:06 PM Bug #13597 (Closed): Does read_nonblock call remalloc for the buffer if does it just set the size attribute
- Hello
I've observed that a lot of memory gets allocated and wasted when read_nonblock is called for a number of by... - 06:59 PM Revision daf14f71 (git): * 2017-05-25
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@58875 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
- 06:59 PM Revision 410362f6 (git): thread_pthread: retry timer thread creation w/o attr on EINVAL
- Setting a small stack size can fail due to having 3rd-party
libraries (e.g. libkqueue) loaded, if those libraries use... -
- * dir.c (glob_helper): prefer NAMLEN, do not assume d_name is NUL
terminated everywhere.
git-svn-id: svn+ssh://ci.... -
- * test/net/http/test_http.rb (test_s_start): git rid of error when
failed to start a connection.
git-svn-id: svn+s... -
-
06:46 AM Bug #13596: Segfault when catching SystemStackError in eval
- Updated description to add a successful testcase.
-
- Here's a GDB trace with VMDEBUG=1 for a Ruby 2.4.1 checkout. It appears that the crash occurs when setting up the fra...
-
- This minimal testcase will crash most ruby versions with a SIGSEGV (though it's likely that other constructions could...
-
- Applied in changeset trunk|r58871.
----------
enum.c: respect method visibility
* enum.c (ary_inject_op): should re... -
06:35 AM Bug #13592: Enumerable#reduce with symbol does not respect method visibility
- i think you still mix reduce(&:+) with reduce(:+)
both are two totally different ways to call this method.
(the lat... -
01:06 AM Bug #13592: Enumerable#reduce with symbol does not respect method visibility
- This is exactly what I am saying.
This behavior of `reduce` is unpredictable and different of the another `Enumera... -
- * enum.c (ary_inject_op): should respect method visibility, do not
optimize uncallable method. [ruby-core:81349] [... -
- * test/ruby/test_enum.rb (test_inject_array_op_redefined): test
other operators too. [Bug#12178]
git-svn-id: svn+... -
- * test/lib/test/unit/assertions.rb (AllFailures#foreach):
shortcircuit for `each` and `AllFailures#for`.
git-svn-i... -
- * test/ruby/test_enum.rb (assert_float_equal): remove overridden
definition.
git-svn-id: svn+ssh://ci.ruby-lang.or... -
- Applied in changeset trunk|r58867.
----------
Improve performance in where push the element into non shared Array ob... -
- * array.c (ary_ensure_room_for_push): use rb_ary_modify_check() instead of
rb_ary_modify() to check whether the o... -
- * string.c (rb_str_crypt): struct crypt_data defined in
missing/crypt.h is small enough.
git-svn-id: svn+ssh://ci.... -
- * debug_counter.h: add the following counters to measure object types.
obj_free: freed count
obj_str_ptr: freed c... - 03:01 AM Revision 144e0670 (git): string.c (rb_str_crypt): fix excessive stack use with crypt_r
- "struct crypt_data" is 131232 bytes on x86-64 GNU/Linux,
making it unsafe to use tiny Fiber stack sizes.
git-svn-id:... -
03:00 AM Bug #13593: Addrinfo#== behaves oddly
- Accurate observation. It does not define equality so falls back to Object's definition, which compares identity.
... -
- Here is the function in full as of current trunk (r58863):
~~~c
static inline void *
rb_alloc_tmp_buffer2(volati... -
12:40 AM Bug #13594: Segfault in gc_sweep_step 2.4.1
- This seems to be caused by some interaction with the `simplecov` gem. I don't understand why, yet, and I have not yet...
- 12:34 AM Revision 2e87ef8b (git): rubyspec/core/io/popen_spec: avoid lingering "ruby -e sleep" process
- The ruby_cmd helper blindly escapes code blocks passed to it,
causing "sleep" to be quoted in the command-line. This...
05/23/2017
-
- reduce(&:+) is different from
reduce(:+), this one has nothing to do with :+.to_proc
reduce/inject with symbol pa... -
-
- Please, reconsider. Look this example:
~~~
irb(main):092:0> :puts.to_proc.call("")
NoMethodError: private meth... -
- The proc returned by `Symbol#to_proc` is equivalent to `proc {|recv, *args| recv.__send__(self, *args)}`.
So it can ... -
- Sorry, ignore the IRB thing. But my question about the reduce still valid.
-
- When use reduce with symbol, I expect the symbol is called in object but respecting the method visibility.
Example... -
- In ruby 2.4.1 I am seeing segfaults in `gc_sweep_step`. These do not occur when I use the same commands in ruby 2.3.4...
-
- I think an exception is the best way to be clear about the problem here, nil or a fake path are most likely to raise ...
-
- This could break methods which take a pathname-like object and call #to_path when a File is passed to them (e.g. File...
-
- MSP-Greg (Greg L) wrote:
> Given that spec tests are not currently included in appveyor, do you know if the test ['d... -
03:39 PM Bug #13591: spec/rubyspec/core/time/zone_spec - Windows does not support ENV['TZ']
- Using a MinGW build, ENV['TZ'] seemed to have no affect on Time, and [time zone spec tests](https://msp-greg.github.i...
-
- MSVCRT uses `TZ`.
See https://msdn.microsoft.com/en-us/library/w4ddyt9h.aspx -
- Windows does not support ENV['TZ'], so it should be removed from rspec tests.
See [GitHub PR 1627](https://github.... -
- ko1 (Koichi Sasada) wrote:
> > we may want to drop OpenBSD <5.2 support
>
> On https://bugs.ruby-lang.org/project... - 04:51 PM Revision 86c9a6d4 (git): * 2017-05-24
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@58862 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- On Solaris 11, MSG_OOB is in readfds?
http://rubyci.org/logs/rubyci.s3.amazonaws.com/unstable11x/ruby-trunk/log/20170... -
03:30 PM Bug #13593 (Rejected): Addrinfo#== behaves oddly
- It appears as if Addrinfo is using object identity. `Addrinfo#==` doesn't appear to work as one might expect, given t...
-
- * dir.c (glob_helper): support Dir instance as `base` option.
[Feature#13056]
git-svn-id: svn+ssh://ci.ruby-lang.o... -
- * test/ruby/test_dir.rb (test_glob_base): sort the globbed result
to compare.
git-svn-id: svn+ssh://ci.ruby-lang.o... -
- * dir.c (dir_s_aref, dir_s_glob): add new optional keyword
argument, `base`. [Feature#13056]
git-svn-id: svn+ssh:... -
- .travis.yml: make srcdir unwritable during build and tests.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@58857 ... -
- * .travis.yml (before_script, script): out-of-place build.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@58856 b... -
- * test/net/http/test_http.rb (test_s_start): finish connections to
get rid of FD leaks.
git-svn-id: svn+ssh://ci.r... -
- * compile.c (LABEL_FORMAT): extract format string for labels.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@5885... -
- * vsnprintf.c (__sFILE): _lbfsize is not used.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@58853 b2dd03c8-39d4... -
10:43 AM Feature #13588: Add Encoding#min_char_size, #max_char_size, #minmax_char_size
- phluid61 (Matthew Kerwin) wrote:
> I hope there are no encodings where valid characters might not be a multiple of t... -
10:31 AM Feature #13588: Add Encoding#min_char_size, #max_char_size, #minmax_char_size
- haines (Andrew Haines) wrote:
>
> ~~~ ruby
> until char.size == max_char_size || eof?
> char << read(min_c... -
- I'm implementing a tar archive reader that takes an arbitrary stream (`StringIO`, `File`, `Zlib::GzipReader`, ...) an...
-
09:17 AM Feature #13588 (Feedback): Add Encoding#min_char_size, #max_char_size, #minmax_char_size
- haines (Andrew Haines) wrote:
> When implementing an IO-like object, I'd like to handle encoding correctly.
This ... -
- This seems to be a leftover of issue #11094.
Keeping the max byte length of UTF-8 at 6 seems to only potentially c... - 06:02 AM Revision 80a4084b (git): Use test-unit 3.2.4
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@58852 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
05:44 AM Bug #13579 (Closed): Net::IMAP#append blocks when a NO response is received
- Fixed in r58792 and r58844.
-
- Error messages are not Markdown.
Use multiline code block to quote them. -
- domaio (Dorian M) wrote:
> Looking at error.c in general, it seems like a rather intentional
Yes. I bekieve this ... -
- appveyor.yml: make srcdir unwritable during build and tests.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@58851... -
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@58850 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
05/22/2017
- 11:41 PM Revision 40a99224 (git): * 2017-05-23
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@58849 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
- 11:41 PM Revision 2ab82704 (git): variable.c (autoload_sleep_done): avoid needless list_node init
- We do not need list_del_init in ensure callbacks, only list_del,
since it can only ever be called after list_del_init... -
09:09 PM Bug #13589: unmatched opening backtick / closing quote in NoMethodError: undefined method `name' for {}:Hash
- Thought about it when trying to explain Struct vs OpenStruct on Stack Overflow :) https://stackoverflow.com/a/4412181...
-
- From [`error.c`](https://github.com/ruby/ruby/blob/trunk/error.c#L1953-L1964):
~~~ c
/*
* Document-class: NoMe... -
- I'm actually fine with whatever name you prefer. result_with_locals and render_with_locals are both fine to me. Thank...
-
- > Or maybe ERB.new(str, locals: {a: b}).result?
For this case, it would have the same problem as ERB.new(str).resu... -
- shugo (Shugo Maeda) wrote:
> r58840 で対策してみましたがどうでしょうか？
手元で何度か試行してみた感じでは、大丈夫っぽく見えます。
rubyciでも問題が出なくなっているようです。
とい... -
- usa (Usaku NAKAMURA) wrote:
> r58792で追加されたテストですが、Windowsでは毎回Errorになります。
> assertion自体は通過してるっぽいですが、テストメソッドから抜ける際に
>... -
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@58847 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
02:11 PM Feature #13588: Add Encoding#min_char_size, #max_char_size, #minmax_char_size
- Seems sensible to me. Guess someone from the ruby core team or matz should chime in and perhaps comment - or someone ...
-
- When implementing an IO-like object, I'd like to handle encoding correctly. To do so, I need to know the minimum and ...
-
- nobu (Nobuyoshi Nakada) wrote:
> Once #13576 is introduced, this issue becomes stale.
> It doesn't make sense to ch... -
- Once #13576 is introduced, this issue becomes stale.
It doesn't make sense to change `File#path`. -
- nobu (Nobuyoshi Nakada) wrote:
> ```sh
> $ ./x86_64-linux/bin/ruby -e 'f = open(File.expand_path("/tmp"), File::RDW... -
- ```sh
$ ./x86_64-linux/bin/ruby -e 'f = open(File.expand_path("/tmp"), File::RDWR|File::TMPFILE); p open(f).read'
T... -
- shyouhei (Shyouhei Urabe) wrote:
> nobu (Nobuyoshi Nakada) wrote:
> > A correction; The method which `open` calls i... -
- nobu (Nobuyoshi Nakada) wrote:
> shyouhei (Shyouhei Urabe) wrote:
> > At the meeting we discussed the use case of `... -
- Took me time for several reasons:
1. Had temporarily ran out of my docker hosts and had to prepare new one. This ... -
- Agree, it has no meanings.
- 07:36 AM Revision cbedbaf9 (git): lib/net/protocol.rb: account read_bytes before caller sees it
- Users may modify the chunk yielded to them in Net::HTTPResponse#read_body.
This will allow users to reduce memory usa... -
- Hash#transform_values! returns the receiver rather than a new Hash
object.
git-svn-id: svn+ssh://ci.ruby-lang.org/ru... -
- Otherwise literal data will be sent even if NO response is returned
because @exception is set to nil in receive_respo... -
- It reproduced "incorrect checksum for freed object", with a fix.
```diff
- Data_Wrap_Struct(rb_cData, NULL, du... -
- nobu (Nobuyoshi Nakada) wrote:
> > ```c
> Data_Wrap_Struct(rb_cData, NULL, dummy_free, &i);
> ```
>
> Wrapp... -
- > ```c
Data_Wrap_Struct(rb_cData, NULL, dummy_free, &i);
```
Wrapping the pointer to a local variable?
Obvi... -
- I reduced repro codes, segv.c and segv.rb.
They cause assertion failure with RGENGC_CHECK_MODE=1.
```
ruby 2.5.0... -
- * tool/downloader.rb (Downloader.link_cache): on Cygwin, make true
symlink only, which is provided by the OS. as m... -
- Applied in changeset trunk|r58842.
----------
erb.rb: Skip creating regexp
if stags and etags are not changed from ... -
- if stags and etags are not changed from default.
:putobject insn (of regexp) will be used instead of :toregexp insn.... -
- * tool/downloader.rb (Downloader.download): just link to the cache
when downloaded to the cache but not the target ...
05/21/2017
- 11:52 PM Revision 8623ba86 (git): lib/net/protocol: clear short-lived read buffer
- Using a parallel Net::HTTP downloader, this reduced memory usage
from around 120MB to 50MB on my 32-bit x86 system.
... -
- I did not include the type check in `str_casecmp`, which seems superfluous to me. I also adjusted the tests, docs, an...
-
- Applied in changeset trunk|r58837.
----------
string.c: fix String#{casecmp,casecmp?} for non-string arguments
* st... -
- * See https://bugs.ruby-lang.org/issues/13312
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@58839 b2dd03c8-39d4-... -
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@58838 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- * string.c: make String#{casecmp,casecmp?} return nil for
non-string arguments instead of raising a TypeError.
* t... -
- * test/ruby/test_string.rb: add more test cases for String#casecmp.
* test/ruby/test_symbol.rb: ditto for Symbol#{cas... -
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@58835 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- Martin showed this example:
> class Array
> class << self
> alias :my_new :new
> end
Ruby allows thi... -
- > Given that it's very easy (as shown by Matthew) to create such a method, do you think it's necessary that this
> b... -
04:51 PM Feature #13587 (Closed): Improve performance of string interpolation
- This patch will add pre-allocation in string interpolation.
By this, unnecessary capacity resizing is avoided.
Fo... - 04:45 PM Revision 4a9a0eaa (git): * 2017-05-22
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@58834 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- * tool/downloader.rb (Downloader.download): manage download cache.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk... -
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@58832 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- * tool/downloader.rb (Downloader::RubyGems.download): utilize
`dir` argument of Downloader.download.
git-svn-id: s... -
07:17 AM Bug #13191 (Open): sample/pty/shl.rb がうまく動かない
-
- Explicitly says that the methods return a new hash rather than just
stating it return a new something we don't know.
... -
- Applied in changeset trunk|r58829.
----------
Improve Time#+ & Time#- performance
* time.c (wadd): use internal add... -
- Applied in changeset trunk|r58828.
----------
Improve Time#<=> performance
* time.c (wcmp): use internal cmp() func... -
- * time.c (wadd): use internal addv() function to calculate internal value in
Time object. On 64-bit machine, Time... -
- * time.c (wcmp): use internal cmp() function for comparing internal Fixnum value
in Time objects. On 64-bit machi... -
- Use character class directly instead of
character class in character class.
git-svn-id: svn+ssh://ci.ruby-lang.org/r...
05/20/2017
-
- [email protected] wrote:
> Only supports Linux:
...And only with sockets where O_NONBLOCK is not set, because
t... -
- Only supports Linux:
```diff
@@ -10372,11 +10383,23 @@ static int
nogvl_wait_for_single_fd(int fd, short events... -
- The concept Net::HTTP#write_timeout sounds fine.
> However adding a Timeout.timeout call around req.exec did work.... -
- I would already suggest a new name when I read about the problems with overriding the current method, so I would agre...
-
-
- I think the names are good, both #transform_keys and #transform_values.
Seem quite clear to me from the names.
... -
08:56 AM Feature #13583: Adding `Hash#transform_keys` method
- I don't think you missed anything, except I would just point out to also add `Hash#transform_keys!`. I don't know if ...
-
- Thank you for issuing this. I see there is an obvious needs for this transformation (stringify_keys) so I'm :+1: to ...
-
06:55 PM Bug #13566 (Assigned): A process freezes at the beginning of C level backtrace when a certain SEGV is occurred
- This issue is not only for NULL but also the other address such as 0x00000000000001.
```
$ ruby -r fiddle -e 'Fid... -
- Hanmac (Hans Mackowiak) wrote:
> as Sorah did there: https://github.com/aws/aws-sdk-ruby/pull/1516
> i would sugges... -
- to unify a behavior with r58823 and r58825.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@58826 b2dd03c8-39d4-4d... -
- Applied in changeset trunk|r58825.
----------
erb.rb: Allow explicit trimming carriage return
when trim_mode is "-"... -
- when trim_mode is "-", for Windows environments.
[ruby-core:39625] [Bug #5339]
git-svn-id: svn+ssh://ci.ruby-lang.o... -
- The current maintainer suggested this in ruby-dev:50113.
Please ping me if an issue happens in ERB.
git-svn-id: svn+... -
- Applied in changeset trunk|r58823.
----------
erb.rb: Allow trimming carriage return
when trim_mode is "<>", for Wi... -
- when trim_mode is "<>", for Windows environments.
[Bug #11464]
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@58... -
04:36 PM Bug #13586 (Closed): Ruby hangs when accessing array which is modified in instance_eval after Coverage.start
- The following code will hang ruby:
~~~
# main.rb
require "coverage"
Coverage.start
require_relative "./f... -
- of LoadError in some method calls, not from `require "strscan"`.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@5... - 03:58 PM Revision 9aa33d5d (git): * 2017-05-21
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@58821 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@58820 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- Original `SimpleScanner` was used only in tests.
Since `SimpleScanner` and `SimpleScanner2` work in the same way, I w... -
- > Can you handle this?
Ok. - 01:00 PM Revision f1e10bd2 (git): * properties.
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@58818 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
01:00 PM Revision 33710d45 (git): Add coverage measurement mode by using gcov
- This experimental feature is only for Ruby-core team, not for casual users.
Usage: `./configure --enable-gcov && mak... -
- shyouhei (Shyouhei Urabe) wrote:
> At the meeting we discussed the use case of `File#path` and we thought there are ... -
- like i said, open with write mode is the problem.
because it didn't fail with the nonexistent path
an way for it ... -
- At the meeting we discussed the use case of `File#path` and we thought there are 2 kinds:
- Pass it to `open()`
-... -
- The order of sed commands in Makefile of ripper was wrong: it tries to
replace `y.tab.c` with `ripper.c`, but before ... -
- * compile.c (compile_branch_condition, iseq_compile_each0):
eliminate unreachable branches in NODE_IF.
git-svn-id:... -
- * compile.c (compile_branch_condition): turn recursion at binary
logical operator into loop by goto, and check the ... -
- * test/test_prime.rb: remove alias after timeout test.
* lib/prime.rb: fix typo.
git-svn-id: svn+ssh://ci.ruby-lang... -
- r58812
-
09:47 AM
Feature #9632 (Closed): [PATCH 0/2] speedup IO#close with linked-list from ccan
- Applied in changeset trunk|r58812.
----------
speed up IO#close with many threads
Today, it increases IO#close perf... - 09:47 AM Revision 508091d9 (git): speed up IO#close with many threads
- Today, it increases IO#close performance with many threads:
Execution time (sec)
name trunk after
... -
- @marcandre
I actually was working on the essentially same fix for the test case and about to commit; only I did wa... -
12:39 AM Bug #13492 (Closed): Integer#prime? and Prime.each might produce false positives
- Good catch.
I tweaked the timeout test by patching `Integer.sqrt`.
-
- Applied in changeset trunk|r58811.
----------
Improve Hash#merge performance
* hash.c (rb_hash_merge): use rb_hash_... -
- * hash.c (rb_hash_merge): use rb_hash_dup() instead of rb_obj_dup() to duplicate
Hash object. rb_hash_dup() is fa... -
- ruby 2.4.2p131 (2017-05-10 revision 58637) [x86_64-linux] で試してみたところ、 r57530 も backport しないと C-z がきかないようです。
exit した... -
05:14 AM Bug #13578: Another iseq_set_sequence: adjust bug
- Thank you. While your test code does NOT repro under 2.4.1p111, it does under trunk. I've verified that this and my o...
-
-
- This can be surprising, but it's in line with many other destructive methods. It can be very useful when writing a lo...
-
- FYI it is intentional for this feature being automatically enabled right now, instead of some configuration like the ...
-
- * compile.c (remove_unreachable_chunk): do not eliminate chunks
followed by labels in catch-table entries.
git-svn... - 12:36 AM Revision 68354c35 (git): lib/prime: Fix primality of some large integers [#13492].
- * lib/prime.rb: Use accurate sqrt to insure all factors are tested.
Patch by Marcus Stollsteimer.
* test/test_prim... -
- Why the version with symbol (`Math->:sqrt`) needs to be supported?
Also available in: Atom