Project

General

Profile

« Previous | Next » 

Revision 6270d595

Added by watson1978 (Shizuo Fujita) about 8 years ago

Improve Array#concat performance if only one argument is given

  • array.c (rb_ary_concat_multi): concatenate the array without generating
    temporary Array object if only one argument is given.
    This is very similar with r58886.

    Array#concat will be faster around 19%.
    [Fix GH-1634]

Before

    Array#concat      2.187M (± 3.5%) i/s -     10.926M in   5.002829s

After

    Array#concat      2.598M (± 1.8%) i/s -     13.008M in   5.008201s

Test code

require 'benchmark/ips'

Benchmark.ips do |x|
x.report "Array#concat" do |i|
other = [4]
i.times { [1, 2, 3].concat(other) }
end
end

git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@58909 b2dd03c8-39d4-4d8f-98ff-823fe69b080e