postgres-xc-developers Mailing List for Postgres-XC

Okay, I understood.   The first hunk removes a sentence which does not make any sense.

Thanks.
---
Koichi Suzuki

2014/04/24 11:46、Masataka Saito <pg...@gm...> のメール：

> On 24 April 2014 11:04, 鈴木 幸市 <ko...@in...> wrote:
>> Thanks a lot Wang;
>> 
>> The first patch may not be effective because handle does not propagate to caller.
>> 
> 
> The variable handle does not propagate to caller.
> Therefore, the first hunk is reasonable.
> 
> Regards.
> 
>> The second one looks reasonable.
>> 
>> Regards;
>> ---
>> Koichi Suzuki
>> 
>> 2014/04/23 22:13、Wang Diancheng <dia...@gm...> のメール：
>> 
>>> Hi,
>>> 
>>> patch attached.
>>> 
>>> diff --git a/src/backend/pgxc/pool/poolmgr.c b/src/backend/pgxc/pool/poolmgr.c
>>> index 02ed656..432fb85 100644
>>> --- a/src/backend/pgxc/pool/poolmgr.c
>>> +++ b/src/backend/pgxc/pool/poolmgr.c
>>> @@ -389,7 +389,6 @@ PoolManagerCloseHandle(PoolHandle *handle)
>>> {
>>>      close(Socket(handle->port));
>>>      free(handle);
>>> -     handle = NULL;
>>> }
>>> 
>>> 
>>> @@ -818,7 +817,7 @@ PoolManagerDisconnect(void)
>>>      pool_putmessage(&poolHandle->port, 'd', NULL, 0);
>>>      pool_flush(&poolHandle->port);
>>> 
>>> -     close(Socket(poolHandle->port));
>>> +     PoolManagerCloseHandle(poolHandle);
>>>      poolHandle = NULL;
>>> }
>>> 
>>> ------------------------------------------------------------------------------
>>> Start Your Social Network Today - Download eXo Platform
>>> Build your Enterprise Intranet with eXo Platform Software
>>> Java Based Open Source Intranet - Social, Extensible, Cloud Ready
>>> Get Started Now And Turn Your Intranet Into A Collaboration Platform
>>> http://p.sf.net/sfu/ExoPlatform_______________________________________________
>>> Postgres-xc-developers mailing list
>>> Pos...@li...
>>> https://lists.sourceforge.net/lists/listinfo/postgres-xc-developers
>> 
>> ------------------------------------------------------------------------------
>> Start Your Social Network Today - Download eXo Platform
>> Build your Enterprise Intranet with eXo Platform Software
>> Java Based Open Source Intranet - Social, Extensible, Cloud Ready
>> Get Started Now And Turn Your Intranet Into A Collaboration Platform
>> http://p.sf.net/sfu/ExoPlatform
>> _______________________________________________
>> Postgres-xc-developers mailing list
>> Pos...@li...
>> https://lists.sourceforge.net/lists/listinfo/postgres-xc-developers
> 

On 24 April 2014 11:04, 鈴木 幸市 <ko...@in...> wrote:
> Thanks a lot Wang;
>
> The first patch may not be effective because handle does not propagate to caller.
>

The variable handle does not propagate to caller.
Therefore, the first hunk is reasonable.

Regards.

> The second one looks reasonable.
>
> Regards;
> ---
> Koichi Suzuki
>
> 2014/04/23 22:13、Wang Diancheng <dia...@gm...> のメール：
>
>> Hi,
>>
>> patch attached.
>>
>> diff --git a/src/backend/pgxc/pool/poolmgr.c b/src/backend/pgxc/pool/poolmgr.c
>> index 02ed656..432fb85 100644
>> --- a/src/backend/pgxc/pool/poolmgr.c
>> +++ b/src/backend/pgxc/pool/poolmgr.c
>> @@ -389,7 +389,6 @@ PoolManagerCloseHandle(PoolHandle *handle)
>> {
>>       close(Socket(handle->port));
>>       free(handle);
>> -     handle = NULL;
>> }
>>
>>
>> @@ -818,7 +817,7 @@ PoolManagerDisconnect(void)
>>       pool_putmessage(&poolHandle->port, 'd', NULL, 0);
>>       pool_flush(&poolHandle->port);
>>
>> -     close(Socket(poolHandle->port));
>> +     PoolManagerCloseHandle(poolHandle);
>>       poolHandle = NULL;
>> }
>>
>> ------------------------------------------------------------------------------
>> Start Your Social Network Today - Download eXo Platform
>> Build your Enterprise Intranet with eXo Platform Software
>> Java Based Open Source Intranet - Social, Extensible, Cloud Ready
>> Get Started Now And Turn Your Intranet Into A Collaboration Platform
>> http://p.sf.net/sfu/ExoPlatform_______________________________________________
>> Postgres-xc-developers mailing list
>> Pos...@li...
>> https://lists.sourceforge.net/lists/listinfo/postgres-xc-developers
>
> ------------------------------------------------------------------------------
> Start Your Social Network Today - Download eXo Platform
> Build your Enterprise Intranet with eXo Platform Software
> Java Based Open Source Intranet - Social, Extensible, Cloud Ready
> Get Started Now And Turn Your Intranet Into A Collaboration Platform
> http://p.sf.net/sfu/ExoPlatform
> _______________________________________________
> Postgres-xc-developers mailing list
> Pos...@li...
> https://lists.sourceforge.net/lists/listinfo/postgres-xc-developers

Thanks a lot Wang;

The first patch may not be effective because handle does not propagate to caller.

The second one looks reasonable.

Regards;
---
Koichi Suzuki

2014/04/23 22:13、Wang Diancheng <dia...@gm...> のメール：

> Hi,
> 
> patch attached.
> 
> diff --git a/src/backend/pgxc/pool/poolmgr.c b/src/backend/pgxc/pool/poolmgr.c
> index 02ed656..432fb85 100644
> --- a/src/backend/pgxc/pool/poolmgr.c
> +++ b/src/backend/pgxc/pool/poolmgr.c
> @@ -389,7 +389,6 @@ PoolManagerCloseHandle(PoolHandle *handle)
> {
> 	close(Socket(handle->port));
> 	free(handle);
> -	handle = NULL;
> }
> 
> 
> @@ -818,7 +817,7 @@ PoolManagerDisconnect(void)
> 	pool_putmessage(&poolHandle->port, 'd', NULL, 0);
> 	pool_flush(&poolHandle->port);
> 
> -	close(Socket(poolHandle->port));
> +	PoolManagerCloseHandle(poolHandle);
> 	poolHandle = NULL;
> }
> 
> ------------------------------------------------------------------------------
> Start Your Social Network Today - Download eXo Platform
> Build your Enterprise Intranet with eXo Platform Software
> Java Based Open Source Intranet - Social, Extensible, Cloud Ready
> Get Started Now And Turn Your Intranet Into A Collaboration Platform
> http://p.sf.net/sfu/ExoPlatform_______________________________________________
> Postgres-xc-developers mailing list
> Pos...@li...
> https://lists.sourceforge.net/lists/listinfo/postgres-xc-developers

Thanks Wang for the patch.   At a glance, it looks nice.   Please let me take a closer look before commit.

Regards;
---
Koichi Suzuki

2014/04/23 22:17、Wang Diancheng <dia...@gm...> のメール：

> Hi,
> 
> patch attached.
> 
> 
> diff --git a/src/backend/access/transam/gtm.c b/src/backend/access/transam/gtm.c
> index 943ce57..087313e 100644
> --- a/src/backend/access/transam/gtm.c
> +++ b/src/backend/access/transam/gtm.c
> @@ -170,12 +170,13 @@ BeginTranAutovacuumGTM(void)
> int
> CommitTranGTM(GlobalTransactionId gxid)
> {
> -	int ret;
> +	int ret = -1;
> 
> 	if (!GlobalTransactionIdIsValid(gxid))
> 		return 0;
> 	CheckConnection();
> -	ret = commit_transaction(conn, gxid);
> +	if (conn)
> +		ret = commit_transaction(conn, gxid);
> 
> 	/*
> 	 * If something went wrong (timeout), try and reset GTM connection.
> @@ -203,12 +204,13 @@ CommitTranGTM(GlobalTransactionId gxid)
> int
> CommitPreparedTranGTM(GlobalTransactionId gxid, GlobalTransactionId prepared_gxid)
> {
> -	int ret = 0;
> +	int ret = -1;
> 
> 	if (!GlobalTransactionIdIsValid(gxid) || !GlobalTransactionIdIsValid(prepared_gxid))
> -		return ret;
> +		return 0;
> 	CheckConnection();
> -	ret = commit_prepared_transaction(conn, gxid, prepared_gxid);
> +	if (conn)
> +		ret = commit_prepared_transaction(conn, gxid, prepared_gxid);
> 
> 	/*
> 	 * If something went wrong (timeout), try and reset GTM connection.
> @@ -257,13 +259,13 @@ StartPreparedTranGTM(GlobalTransactionId gxid,
> 					 char *gid,
> 					 char *nodestring)
> {
> -	int ret = 0;
> +	int ret = -1;
> 
> 	if (!GlobalTransactionIdIsValid(gxid))
> 		return 0;
> 	CheckConnection();
> -
> -	ret = start_prepared_transaction(conn, gxid, gid, nodestring);
> +	if (conn)
> +		ret = start_prepared_transaction(conn, gxid, gid, nodestring);
> 
> 	/*
> 	 * If something went wrong (timeout), try and reset GTM connection.
> @@ -282,12 +284,13 @@ StartPreparedTranGTM(GlobalTransactionId gxid,
> int
> PrepareTranGTM(GlobalTransactionId gxid)
> {
> -	int ret;
> +	int ret = -1;
> 
> 	if (!GlobalTransactionIdIsValid(gxid))
> 		return 0;
> 	CheckConnection();
> -	ret = prepare_transaction(conn, gxid);
> +	if (conn)
> +		ret = prepare_transaction(conn, gxid);
> 
> 	/*
> 	 * If something went wrong (timeout), try and reset GTM connection.
> @@ -310,11 +313,12 @@ GetGIDDataGTM(char *gid,
> 			  GlobalTransactionId *prepared_gxid,
> 			  char **nodestring)
> {
> -	int ret = 0;
> +	int ret = -1;
> 
> 	CheckConnection();
> -	ret = get_gid_data(conn, GTM_ISOLATION_RC, gid, gxid,
> -					   prepared_gxid, nodestring);
> +	if (conn)
> +		ret = get_gid_data(conn, GTM_ISOLATION_RC, gid, gxid,
> +						   prepared_gxid, nodestring);
> 
> 	/*
> 	 * If something went wrong (timeout), try and reset GTM connection.
> ------------------------------------------------------------------------------
> Start Your Social Network Today - Download eXo Platform
> Build your Enterprise Intranet with eXo Platform Software
> Java Based Open Source Intranet - Social, Extensible, Cloud Ready
> Get Started Now And Turn Your Intranet Into A Collaboration Platform
> http://p.sf.net/sfu/ExoPlatform_______________________________________________
> Postgres-xc-developers mailing list
> Pos...@li...
> https://lists.sourceforge.net/lists/listinfo/postgres-xc-developers

Hi,

patch attached.

Hi,

patch attached.

Now Postgres-XC 1.0.4 and Postgres-XC 1.1.1 are available.   They come
with various fixes/improvements as seen in each release note.

For 1.1.1,
Release note is available at
http://postgres-xc.sourceforge.net/docs/1_1_1/release-xc-1-1-1.html
Source tarball is available at
https://sourceforge.net/projects/postgres-xc/files/Version_1.1/
Document is available at http://postgres-xc.sourceforge.net/docs/1_1_1/

For 1.0.4
Release note is available at
http://postgres-xc.sourceforge.net/docs/1_0_4/release-xc-1-0-4.html
Source tarball is available at
https://sourceforge.net/projects/postgres-xc/files/Version_1.0/
Document is available at http://postgres-xc.sourceforge.net/docs/1_0_4/

Enjoy;
---
Koichi Suzuki

that's the good news.


On Thu, Apr 3, 2014 at 11:54 AM, Koichi Suzuki <koi...@gm...>wrote:

> Postgres-XC development group is pleased to announce that Postgres-XC
> 1.2.1 is out.
>
> This includes many important features from PostgreSQL 9.3 such as
> materialized views, LATERAL, event triggers and automatic updatable
> views, as well as improved distributed query optimizer.   It also
> comes with many fixes and improvement as found in the release note.
>
> Release note is available at
> http://postgres-xc.sourceforge.net/docs/1_2_beta/release-xc-1-2.html
> Source tarball is available at
> https://sourceforge.net/projects/postgres-xc/files/Version_1.2/
> Document is available at http://postgres-xc.sourceforge.net/docs/1_2_1/
>
> Enjoy.
> ---
> Koichi Suzuki
>
>
> ------------------------------------------------------------------------------
> _______________________________________________
> Postgres-xc-general mailing list
> Pos...@li...
> https://lists.sourceforge.net/lists/listinfo/postgres-xc-general
>



-- 
Thanks,
Juned Khan
iNextrix Technologies Pvt Ltd.
www.inextrix.com

Postgres-XC development group is pleased to announce that Postgres-XC
1.2.1 is out.

This includes many important features from PostgreSQL 9.3 such as
materialized views, LATERAL, event triggers and automatic updatable
views, as well as improved distributed query optimizer.   It also
comes with many fixes and improvement as found in the release note.

Release note is available at
http://postgres-xc.sourceforge.net/docs/1_2_beta/release-xc-1-2.html
Source tarball is available at
https://sourceforge.net/projects/postgres-xc/files/Version_1.2/
Document is available at http://postgres-xc.sourceforge.net/docs/1_2_1/

Enjoy.
---
Koichi Suzuki

Thank you very much for the patch.   It looks nice.   I tested it
against master and REL1_2_STABLE and found it works fine with the
barrier.   This will be a part of 1.2.1 and current master.

Thank you again.   I'd like to see more of such patches from you.

Regards;
---
Koichi Suzuki


2014-04-01 16:17 GMT+09:00 Wang Diancheng <dia...@gm...>:
> Hi,
>
> pg_xlogdump in current contrib directory could not be compiled, this is
> the patch.
>
> --
> Best Regards,
> Wang Diancheng
>
>
> ------------------------------------------------------------------------------
>
> _______________________________________________
> Postgres-xc-developers mailing list
> Pos...@li...
> https://lists.sourceforge.net/lists/listinfo/postgres-xc-developers
>

Hi,

pg_xlogdump in current contrib directory could not be compiled, this is
the patch.

-- 
Best Regards,
Wang Diancheng