(Complete) Pickaxe

  1. #9576: New template system

    This introduced global $theme_engine in 2004, using literally the same code as in HEAD today. ;)

  2. #19590: Lazy loading of theme system
  3. #51845: avoid code duplication in phptemplate derived theme engines
  4. #130987: Create a registry for theme functions and theme templates
  5. #678714: Unify use of theme hook / template suggestions, fix clobbering problems, and improve suggestion discovery performance

Proposed solution

  1. global $theme_engine is the same a global $theme->engine.
  2. Remove it.
CommentFileSizeAuthor
#2 drupal8.global-theme-engine.2.patch3.87 KBsun

Comments

sun’s picture

sun
Primary language German
Location Karlsruhe
commented
Parent issue: » #2228093: Modernize theme initialization
sun’s picture

sun
Primary language German
Location Karlsruhe
commented
Issue summary: View changes
Status: Active » Needs review
StatusFileSize
new drupal8.global-theme-engine.2.patch3.87 KB

Status: Needs review » Needs work

The last submitted patch, 2: drupal8.global-theme-engine.2.patch, failed testing.

sun’s picture

sun
Primary language German
Location Karlsruhe
commented
Status: Needs work » Postponed

Heh, yeah. Same confusion as in #2228183: Remove global $theme_key ;-)

Let's postpone this on #2228201: Replace global $theme with global $theme_info

cosmicdreams’s picture

cosmicdreams commented
Status: Postponed » Active

A lot has happened since this was postponed, including having #2228201: Replace global $theme with global $theme_info fixed. Reactivating this issue. following.

sun’s picture

sun
Primary language German
Location Karlsruhe
commented
Status: Active » Closed (duplicate)

Obsoleted by #2228093: Modernize theme initialization, unless I'm terribly mistaken.

cosmicdreams’s picture

cosmicdreams commented

You're right @sun, just checked all of core and there is no more global $theme_*