Problem/Motivation
The environment_indicator entity forms don't have form titles, so when you view the form in the Seven theme, you just see the shortcut star button.
Proposed resolution
Add form titles to the add/edit entity form pages, like other entity forms in Drupal core.
Remaining tasks
Redefine the environment_indicator.default form handler as separate add/edit handlers, so we can detect the operation in the form builder method, and use a different title for each.
Set the title of the edit form dynamically, with the entity label.
User interface changes
The admin pages to add/edit an environment get proper titles.
API changes
The environment_indicator config entity type gets separate form handler names, but they still use the same EntityForm class.
Data model changes
None.
| Comment | File | Size | Author |
|---|---|---|---|
| #3 | 3073701-3.patch | 2.24 KB | andrewmacpherson |
Issue fork environment_indicator-3073701
Show commands
Start within a Git clone of the project using the version control instructions.
Or, if you do not have SSH keys set up on git.drupalcode.org:
Comments
Comment #2
andrewmacpherson commentedComment #3
andrewmacpherson commentedComment #4
tessa bakkerIt's better to use
_title_callbackin the route definition. Seenode.routing.ymlfor an example.Comment #7
trackleft2I've updated this to add dynamic title handling for the edit and delete form pages, and put it in a merge request with a tugboat preview.
Comment #8
trackleft2Comment #9
trackleft2