Problem/Motivation

The environment_indicator entity forms don't have form titles, so when you view the form in the Seven theme, you just see the shortcut star button.

Proposed resolution

Add form titles to the add/edit entity form pages, like other entity forms in Drupal core.

Remaining tasks

Redefine the environment_indicator.default form handler as separate add/edit handlers, so we can detect the operation in the form builder method, and use a different title for each.
Set the title of the edit form dynamically, with the entity label.

User interface changes

The admin pages to add/edit an environment get proper titles.

API changes

The environment_indicator config entity type gets separate form handler names, but they still use the same EntityForm class.

Data model changes

None.

CommentFileSizeAuthor
#3 3073701-3.patch2.24 KBandrewmacpherson
Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

Comments

andrewmacpherson created an issue. See original summary.

andrewmacpherson’s picture

Issue summary: View changes
andrewmacpherson’s picture

Status: Active » Needs review
StatusFileSize
new2.24 KB
tessa bakker’s picture

Version: 8.x-3.x-dev » 4.x-dev
Status: Needs review » Needs work

It's better to use _title_callback in the route definition. See node.routing.yml for an example.

trackleft2 made their first commit to this issue’s fork.

trackleft2’s picture

Status: Needs work » Needs review

I've updated this to add dynamic title handling for the edit and delete form pages, and put it in a merge request with a tugboat preview.

trackleft2’s picture

trackleft2’s picture

Status: Needs review » Fixed

  • trackleft2 committed f8d509ca on 4.x
    Issue #3073701 by trackleft2, andrewmacpherson, tess bakker: Add page...

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.