Do not provide links to related/relationship routes for internal resource types.

#2937279: [META] Introduce concept of internal resource types says this is minor, but this issue is marked major. Which is it?

👍

1. +++ b/tests/src/Functional/InternalEntitiesTest.php
   @@ -154,4 +154,25 @@ class InternalEntitiesTest extends BrowserTestBase {
   +    if (!method_exists(EntityTypeInterface::class, 'isInternal')) {
   +      $this->markTestSkipped('The Drupal Core version must be >= 8.5');
   +      return;
   +    }
   +    $this->drupalLogin($this->testUser);
   +    $entity_type_id = $this->referencingEntity->getEntityTypeId();
   +    $bundle = $this->referencingEntity->bundle();
   +    $path = "/jsonapi/{$entity_type_id}/{$bundle}/{$this->referencingEntity->uuid()}";
   +    $response = $this->drupalGet($path, [], ['Accept' => 'application/vnd.api+json']);
   

   This is 90% duplicating \Drupal\Tests\jsonapi\Functional\InternalEntitiesTest::testIncludes().

   I think it makes sense to refactor to share code now — because now there's clearly multiple callers. (::testEntryPoint() is another one.)

2. +++ b/tests/src/Unit/Normalizer/Value/RelationshipNormalizerValueTest.php
   @@ -27,10 +27,14 @@ class RelationshipNormalizerValueTest extends UnitTestCase {
   +    $resource_type = new ResourceType($this->randomMachineName(), $this->randomMachineName(), NULL);
   

   This is not testing an internal resource type? Why then are we changing this? I think I'm missing something obvious, sorry :(

3. +++ b/src/Normalizer/Value/RelationshipNormalizerValue.php
   @@ -85,23 +85,42 @@ class RelationshipNormalizerValue extends FieldNormalizerValue {
   +    $resource_types = $this->resourceType->getRelatableResourceTypesByField($field_name);
   +    if (static::hasNonInternalResourceType($resource_types)) {
   +      $links['related'] = $this->linkManager->getEntityLink(
            $this->hostEntityId,
            $this->resourceType,
            $route_parameters,
            'related'
   -      ),
   -    ];
   +      );
   +    }
   

   AFAICT this means that we never set the related link? Even if there's 10 relatable resource types that are non-internal, and a single one that is internal?

1. ✔️
2. Ok.
3. ✔️ (oops!)

Marking NR to get this patch tested.

Weird, #12 should totally have triggered testing of #11.

1. +++ b/src/Normalizer/Value/RelationshipNormalizerValue.php
   @@ -65,33 +65,63 @@ class RelationshipNormalizerValue extends FieldNormalizerValue {
   +    // @link http://jsonapi.org/format/#document-resource-object-linkage
   

   I totally forgot about @link! ❤️

2. +++ b/tests/src/Functional/InternalEntitiesTest.php
   @@ -154,4 +132,73 @@ class InternalEntitiesTest extends BrowserTestBase {
   +    $decoded = $this->getIndividual($this->referencingEntity);
   

   If we use $document elsewhere, then why not also here?

   Fixing on commit.

💥

Thank you for taking care of this guys!