From: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
---|---|
To: | pgsql-committers(at)postgresql(dot)org |
Subject: | pgsql: Fix write-past-buffer-end in ldapServiceLookup(). |
Date: | 2011-05-12 15:58:36 |
Message-ID: | [email protected] |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-committers |
Fix write-past-buffer-end in ldapServiceLookup().
The code to assemble ldap_get_values_len's output into a single string
wrote the terminating null one byte past where it should. Fix that,
and make some other cosmetic adjustments to make the code a trifle more
readable and more in line with usual Postgres coding style.
Also, free the "result" string when done with it, to avoid a permanent
memory leak.
Bug report and patch by Albe Laurenz, cosmetic adjustments by me.
Branch
------
REL9_0_STABLE
Details
-------
http://git.postgresql.org/pg/commitdiff/30cf86fdf49ec6a5c74aab6dcd7cef78e7f1dd54
Modified Files
--------------
src/interfaces/libpq/fe-connect.c | 20 +++++++++++++-------
1 files changed, 13 insertions(+), 7 deletions(-)
From | Date | Subject | |
---|---|---|---|
Next Message | Robert Haas | 2011-05-12 21:10:49 | pgsql: Kill stray "not". |
Previous Message | Alvaro Herrera | 2011-05-12 12:53:56 | pgsql: Fix assorted typos |