From: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
---|---|
To: | pgsql-committers(at)postgresql(dot)org |
Subject: | pgsql: Fix multiple minor infelicities in aclchk.c error reports. |
Date: | 2016-06-13 17:53:41 |
Message-ID: | [email protected] |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-committers |
Fix multiple minor infelicities in aclchk.c error reports.
pg_type_aclmask reported the wrong type's OID when complaining that
it could not find a type's typelem. It also failed to provide a
suitable errcode when the initially given OID doesn't exist (which
is a user-facing error, since that OID can be user-specified).
pg_foreign_data_wrapper_aclmask and pg_foreign_server_aclmask likewise
lacked errcode specifications. Trivial cosmetic adjustments too.
The wrong-type-OID problem was reported by Petru-Florin Mihancea in
bug #14186; the other issues noted by me while reading the code.
These errors all seem to be aboriginal in the respective routines, so
back-patch as necessary.
Report: <20160613163159(dot)5798(dot)52928(at)wrigleys(dot)postgresql(dot)org>
Branch
------
REL9_1_STABLE
Details
-------
http://git.postgresql.org/pg/commitdiff/bdf39b2c577a107063dfbbe398ff77c5b65ba731
Modified Files
--------------
src/backend/catalog/aclchk.c | 6 ++++--
1 file changed, 4 insertions(+), 2 deletions(-)
From | Date | Subject | |
---|---|---|---|
Next Message | Robert Haas | 2016-06-14 13:00:26 | pgsql: postgres_fdw: Promote an Assert() to elog(). |
Previous Message | Tom Lane | 2016-06-13 16:59:33 | pgsql: In planner.c, avoid assuming that all PathTargets have sortgroup |