pgsql: Fix unportable usage of <ctype.h> functions.

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: pgsql-committers(at)postgresql(dot)org
Subject: pgsql: Fix unportable usage of <ctype.h> functions.
Date: 2017-11-07 18:50:21
Message-ID: [email protected]
Views: Whole Thread | Raw Message | Download mbox | Resend email
Thread:
Lists: pgsql-committers

Fix unportable usage of <ctype.h> functions.

isdigit(), isspace(), etc are likely to give surprising results if passed a
signed char. We should always cast the argument to unsigned char to avoid
that. Error in commit 63d6b97fd, found by buildfarm member gaur.
Back-patch to 9.3, like that commit.

Branch
------
REL9_4_STABLE

Details
-------
https://git.postgresql.org/pg/commitdiff/7a15fe5a2240244e2f80f25adfe6b9a34787a021

Modified Files
--------------
src/interfaces/ecpg/ecpglib/data.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

Browse pgsql-committers by date

  From Date Subject
Next Message Tom Lane 2017-11-07 18:54:40 pgsql: Fix unportable spelling of int64 constant.
Previous Message Andres Freund 2017-11-07 18:01:16 Re: pgsql: Remove secondary checkpoint