pgsql: Forbid marking an identity column as nullable.

Forbid marking an identity column as nullable.

GENERATED ALWAYS AS IDENTITY implies NOT NULL, but the code failed
to complain if you overrode that with "GENERATED ALWAYS AS IDENTITY
NULL". One might think the old behavior was a feature, but it was
inconsistent because the outcome varied depending on the order of
the clauses, so it seems to have been just an oversight.

Per bug #16913 from Pavel Boev. Back-patch to v10 where identity
columns were introduced.

Vik Fearing (minor tweaks by me)

Discussion: https://postgr.es/m/[email protected]

Branch
------
REL_11_STABLE

Details
-------
https://git.postgresql.org/pg/commitdiff/6c34f186c4c62ac93b8f5f7229b03301b02741c9

Modified Files
--------------
doc/src/sgml/ref/create_table.sgml | 1 +
src/backend/parser/parse_utilcmd.c | 10 ++++++++++
src/test/regress/expected/identity.out | 13 +++++++++++++
src/test/regress/sql/identity.sql | 9 +++++++++
4 files changed, 33 insertions(+)