Re: Small TAP tests cleanup for Windows and unused modules

From: Michael Paquier <michael(at)paquier(dot)xyz>
To: Andrew Dunstan <andrew(at)dunslane(dot)net>
Cc: Daniel Gustafsson <daniel(at)yesql(dot)se>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>
Subject: Re: Small TAP tests cleanup for Windows and unused modules
Date: 2022-02-17 01:38:00
Message-ID: [email protected]
Views: Whole Thread | Raw Message | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Wed, Feb 16, 2022 at 05:36:14PM -0500, Andrew Dunstan wrote:
> More specifically, all the tests in question are now passing on jacana
> and fairywren, and their $Config{osname} is NOT 'msys' (it's 'MSWin32').

Indeed. 0001 is incorrect.

> So we should simply remove any line that ends "if $Config{osname} eq
> 'msys';" since we don't have any such animals any more.

So, that's related to [1], meaning that we don't have any buildfarm
members that run the perl flavor from Msys. And, as a result, we
don't need to worry about the CRLF conversions in any of the perl
modules? That would be nice.

[1]: https://www.postgresql.org/message-id/[email protected]
--
Michael

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Jeevan Ladhe 2022-02-17 01:46:22 Re: refactoring basebackup.c
Previous Message Tom Lane 2022-02-17 01:28:02 Re: libpq async duplicate error results