pgsql/ oc/src/sgml/catalogs.sgml oc/src/sgml/r ...

CVSROOT: /cvsroot
Module name: pgsql
Changes by: tgl(at)postgresql(dot)org 02/07/12 14:43:20

Modified files:
doc/src/sgml : catalogs.sgml release.sgml
doc/src/sgml/ref: alter_table.sgml comment.sgml
drop_aggregate.sgml drop_domain.sgml
drop_function.sgml drop_index.sgml
drop_language.sgml drop_operator.sgml
drop_rule.sgml drop_sequence.sgml
drop_table.sgml drop_trigger.sgml
drop_type.sgml drop_view.sgml
src/backend/bootstrap: bootparse.y
src/backend/catalog: Makefile heap.c index.c indexing.c
namespace.c pg_type.c
src/backend/commands: aggregatecmds.c cluster.c comment.c
dbcommands.c functioncmds.c indexcmds.c
operatorcmds.c proclang.c tablecmds.c
trigger.c typecmds.c view.c
src/backend/nodes: copyfuncs.c equalfuncs.c outfuncs.c
src/backend/parser: analyze.c gram.y
src/backend/rewrite: rewriteDefine.c rewriteRemove.c
rewriteSupport.c
src/backend/tcop: utility.c
src/backend/utils/cache: lsyscache.c relcache.c
src/bin/initdb : initdb.sh
src/bin/pg_dump: pg_dump.c
src/bin/psql : describe.c
src/include/access: tupdesc.h
src/include/catalog: catname.h catversion.h heap.h index.h
indexing.h
src/include/commands: comment.h defrem.h proclang.h trigger.h
src/include/nodes: parsenodes.h
src/include/rewrite: rewriteRemove.h
src/include/utils: lsyscache.h
src/test/regress/expected: alter_table.out domain.out
foreign_key.out sanity_check.out
src/test/regress/output: constraints.source
src/test/regress/sql: alter_table.sql domain.sql foreign_key.sql
Added files:
src/backend/catalog: dependency.c pg_constraint.c pg_depend.c
src/include/catalog: dependency.h pg_constraint.h pg_depend.h
Removed files:
src/include/catalog: pg_relcheck.h

Log message:
Second phase of committing Rod Taylor's pg_depend/pg_constraint patch.
pg_relcheck is gone; CHECK, UNIQUE, PRIMARY KEY, and FOREIGN KEY
constraints all have real live entries in pg_constraint. pg_depend
exists, and RESTRICT/CASCADE options work on most kinds of DROP;
however, pg_depend is not yet very well populated with dependencies.
(Most of the ones that are present at this point just replace formerly
hardwired associations, such as the implicit drop of a relation's pg_type
entry when the relation is dropped.) Need to add more logic to create
dependency entries, improve pg_dump to dump constraints in place of
indexes and triggers, and add some regression tests.

Is it at all a problem that several columns in pg_conversion have the same
name as columns in pg_constraint?

Should the ones in pg_conversion become: convname instead of conname, etc.
simply for clarity?

Chris

----- Original Message -----

> Log message:
> Second phase of committing Rod Taylor's pg_depend/pg_constraint patch.
> pg_relcheck is gone; CHECK, UNIQUE, PRIMARY KEY, and FOREIGN KEY
> constraints all have real live entries in pg_constraint. pg_depend
> exists, and RESTRICT/CASCADE options work on most kinds of DROP;
> however, pg_depend is not yet very well populated with dependencies.
> (Most of the ones that are present at this point just replace formerly
> hardwired associations, such as the implicit drop of a relation's pg_type
> entry when the relation is dropped.) Need to add more logic to create
> dependency entries, improve pg_dump to dump constraints in place of
> indexes and triggers, and add some regression tests.
>
>
> ---------------------------(end of broadcast)---------------------------
> TIP 6: Have you searched our list archives?
>
> http://archives.postgresql.org
>

"Christopher Kings-Lynne" <chriskl(at)familyhealth(dot)com(dot)au> writes:
> Is it at all a problem that several columns in pg_conversion have the same
> name as columns in pg_constraint?
> Should the ones in pg_conversion become: convname instead of conname, etc.
> simply for clarity?

Perhaps so. The two patches were developed independently and so no one
thought about it. I don't have a strong feeling about which set of
names to change, although perhaps pg_conversion is referenced in fewer
places at the moment.

Tatsuo, any opinions?

regards, tom lane