pgsql: Minor improvement: avoid assuming that GetLastError value cannot

Lists: pgsql-committers
From: tgl(at)postgresql(dot)org (Tom Lane)
To: pgsql-committers(at)postgresql(dot)org
Subject: pgsql: Minor improvement: avoid assuming that GetLastError value cannot
Date: 2009-05-05 21:51:46
Message-ID: [email protected]
Views: Raw Message | Whole Thread | Download mbox | Resend email
Lists: pgsql-committers

Log Message:
-----------
Minor improvement: avoid assuming that GetLastError value cannot be
affected by CloseHandle() or Sleep().

Modified Files:
--------------
pgsql/src/backend/port:
win32_shmem.c (r1.9 -> r1.10)
(http://anoncvs.postgresql.org/cvsweb.cgi/pgsql/src/backend/port/win32_shmem.c?r1=1.9&r2=1.10)

From: Magnus Hagander <magnus(at)hagander(dot)net>
To: Tom Lane <tgl(at)postgresql(dot)org>
Cc: pgsql-committers(at)postgresql(dot)org
Subject: Re: pgsql: Minor improvement: avoid assuming that GetLastError value cannot
Date: 2009-05-06 09:15:39
Message-ID: [email protected]
Views: Raw Message | Whole Thread | Download mbox | Resend email
Lists: pgsql-committers

Any reason you didn't backport this to the other versions that got the
SetLastError() fix?

//Magnus

Tom Lane wrote:
> Log Message:
> -----------
> Minor improvement: avoid assuming that GetLastError value cannot be
> affected by CloseHandle() or Sleep().
>
> Modified Files:
> --------------
> pgsql/src/backend/port:
> win32_shmem.c (r1.9 -> r1.10)
> (http://anoncvs.postgresql.org/cvsweb.cgi/pgsql/src/backend/port/win32_shmem.c?r1=1.9&r2=1.10)
>

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: Magnus Hagander <magnus(at)hagander(dot)net>
Cc: pgsql-committers(at)postgresql(dot)org
Subject: Re: pgsql: Minor improvement: avoid assuming that GetLastError value cannot
Date: 2009-05-06 13:38:09
Message-ID: [email protected]
Views: Raw Message | Whole Thread | Download mbox | Resend email
Lists: pgsql-committers

Magnus Hagander <magnus(at)hagander(dot)net> writes:
> Any reason you didn't backport this to the other versions that got the
> SetLastError() fix?

AFAIK it's just a cosmetic improvement. If you think there's a
significant risk then back-port away...

regards, tom lane

From: Magnus Hagander <magnus(at)hagander(dot)net>
To: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Cc: pgsql-committers(at)postgresql(dot)org
Subject: Re: pgsql: Minor improvement: avoid assuming that GetLastError value cannot
Date: 2009-05-06 13:39:33
Message-ID: [email protected]
Views: Raw Message | Whole Thread | Download mbox | Resend email
Lists: pgsql-committers

Tom Lane wrote:
> Magnus Hagander <magnus(at)hagander(dot)net> writes:
>> Any reason you didn't backport this to the other versions that got the
>> SetLastError() fix?
>
> AFAIK it's just a cosmetic improvement. If you think there's a
> significant risk then back-port away...

Not really, but it'd be easier if we need to backpatch more stuff later
if the source files are the same at least :-)

//Magnus