pgsql: postgres_fdw: When sending ORDER BY, always include NULLS FIRST/

Lists: pgsql-committers
From: Robert Haas <rhaas(at)postgresql(dot)org>
To: pgsql-committers(at)postgresql(dot)org
Subject: pgsql: postgres_fdw: When sending ORDER BY, always include NULLS FIRST/
Date: 2016-03-04 16:40:25
Message-ID: [email protected]
Views: Raw Message | Whole Thread | Download mbox | Resend email
Lists: pgsql-committers

postgres_fdw: When sending ORDER BY, always include NULLS FIRST/LAST.

Previously, we included NULLS FIRST when appropriate but relied on the
default behavior to be NULLS LAST. This is, however, not true for a
sort in descending order and seems like a fragile assumption anyway.

Report by Rajkumar Raghuwanshi. Patch by Ashutosh Bapat. Review
comments from Michael Paquier and Tom Lane.

Branch
------
master

Details
-------
http://git.postgresql.org/pg/commitdiff/3bea3f88d5fc3517042ba83d2906979256da2442

Modified Files
--------------
contrib/postgres_fdw/deparse.c | 2 +
contrib/postgres_fdw/expected/postgres_fdw.out | 142 +++++++++++++++++++------
contrib/postgres_fdw/sql/postgres_fdw.sql | 12 +++
3 files changed, 125 insertions(+), 31 deletions(-)