Project

General

Profile

« Previous | Next » 

Revision 23780

Added by Go MAEDA about 1 month ago

Avoid adding "%" suffix in CSV export for Progress Bar custom fields to prevent import errors (#42335, #42706).

Patch by Kenta Kumojima (Kenta Kumojima).

View differences:

trunk/lib/redmine/field_format.rb
1145 1145
      end
1146 1146

  
1147 1147
      def formatted_value(view, custom_field, value, customized=nil, html=false)
1148
        text = "#{value}%"
1149 1148
        if html
1149
          text = "#{value}%"
1150 1150
          view.progress_bar(value.to_i, legend: (text if view.action_name == 'show'))
1151 1151
        else
1152
          text
1152
          value.to_s
1153 1153
        end
1154 1154
      end
1155 1155
    end
trunk/test/unit/lib/redmine/field_format/progressbar_format_test.rb
116 116
        end
117 117
      end
118 118
    end
119

  
120
    def test_formatted_value_with_html_true
121
      expected = progress_bar(50)
122
      formatted = @format.formatted_value(self, @field, 50, Issue.new, true)
123
      assert_equal expected, formatted
124
      assert formatted.html_safe?
125
    end
126

  
127
    def test_formatted_value_with_html_false
128
      formatted = @format.formatted_value(self, @field, 50, Issue.new, false)
129
      assert_equal '50', formatted
130
    end
119 131
  end
120 132
end

Also available in: Unified diff