[#23657] [Bug #1550] String#lstrip! raises RuntimeError on Frozen String Despite Making No Changes — Run Paint Run Run <redmine@...>
Bug #1550: String#lstrip! raises RuntimeError on Frozen String Despite Making No Changes
13 messages
2009/06/01
[#23662] Re: [Bug #1550] String#lstrip! raises RuntimeError on Frozen String Despite Making No Changes
— Yukihiro Matsumoto <matz@...>
2009/06/01
Hi,
[#23663] Re: [Bug #1550] String#lstrip! raises RuntimeError on Frozen String Despite Making No Changes
— James Gray <james@...>
2009/06/01
On Jun 1, 2009, at 5:07 PM, Yukihiro Matsumoto wrote:
[#23664] Re: [Bug #1550] String#lstrip! raises RuntimeError on Frozen String Despite Making No Changes
— Yukihiro Matsumoto <matz@...>
2009/06/01
Hi,
[#23672] [Bug #1550](Closed) String#lstrip! raises RuntimeError on Frozen String Despite Making No Changes
— Yukihiro Matsumoto <redmine@...>
2009/06/02
Issue #1550 has been updated by Yukihiro Matsumoto.
[#23675] Re: [Bug #1550](Closed) String#lstrip! raises RuntimeError on Frozen String Despite Making No Changes
— Alex <imphasing@...>
2009/06/02
This change seems to break the build on my machine:
[#23683] [Bug #1560] multi core operations are slower on trunk (possible regression) — David Cuadrado <redmine@...>
Bug #1560: multi core operations are slower on trunk (possible regression)
6 messages
2009/06/03
[#23700] Standard Ruby bytecode — Ioannis Nousias <s0238762@...>
I came across this post:
4 messages
2009/06/04
[#23717] [Bug #1573] $0 behaves unexpectedly — Morris Brodersen <redmine@...>
Bug #1573: $0 behaves unexpectedly
7 messages
2009/06/05
[#23727] [Bug #1580] TestIOScanF failure in windows — Roger Pack <redmine@...>
Bug #1580: TestIOScanF failure in windows
4 messages
2009/06/05
[#23729] [Bug #1583] Time + String no Longer Raises TypeError? — Run Paint Run Run <redmine@...>
Bug #1583: Time + String no Longer Raises TypeError?
14 messages
2009/06/05
[#23743] [Bug #1583] Time + String no Longer Raises TypeError?
— Akira Tanaka <redmine@...>
2009/06/07
Issue #1583 has been updated by Akira Tanaka.
[#23746] Re: [Bug #1583] Time + String no Longer Raises TypeError?
— Yukihiro Matsumoto <matz@...>
2009/06/07
Hi,
[#23748] Re: [Bug #1583] Time + String no Longer Raises TypeError?
— Eero Saynatkari <ruby-ml@...>
2009/06/07
Excerpts from Yukihiro Matsumoto's message of Sun Jun 07 17:07:06 +0300 2009:
[#23738] Ducktyping interface — Yehuda Katz <wycats@...>
Matz,
6 messages
2009/06/07
[#23753] [Bug #1587] Problem with string sharing — Quet Zal <redmine@...>
Bug #1587: Problem with string sharing
4 messages
2009/06/08
[#23770] [Bug #1595] rake unusable on windows install — Robert Gonzalez <redmine@...>
Bug #1595: rake unusable on windows install
10 messages
2009/06/09
[#23815] inheriting socket in child process on native Windows — "Knutaf" <knutaf@...>
Hello,
9 messages
2009/06/12
[#23818] Re: inheriting socket in child process on native Windows
— Roger Pack <rogerdpack@...>
2009/06/12
> This works on Linux by persisting socket.fileno from the parent process a=
[#23820] Re: inheriting socket in child process on native Windows
— Knutaf H <knutaf@...>
2009/06/12
Well, I'm already not exactly using pure Ruby, since I'm wrapping
[#23822] Re: inheriting socket in child process on native Windows
— Roger Pack <rogerdpack@...>
2009/06/12
> Besides that, I think using WSADuplicateSocket will suffer from the
[#23837] Re: inheriting socket in child process on native Windows
— "Knutaf" <knutaf@...>
2009/06/13
I tried that with both the HANDLE value and with an fd value that I
[#23838] Re: inheriting socket in child process on native Windows
— Roger Pack <rogerdpack@...>
2009/06/13
> I tried that with both the HANDLE value and with an fd value that I
[#23842] request for updated ri/rdoc on 1.8.7 branch — Roger Pack <rogerdpack@...>
would it be possible to get a newer version of ri/rdoc installed on
3 messages
2009/06/13
[#23845] [Bug #1627] Kernel.require Should Canonicalise Paths — Run Paint Run Run <redmine@...>
Bug #1627: Kernel.require Should Canonicalise Paths
5 messages
2009/06/13
[#23849] [Bug #1629] [Segfault] z = Zlib::GzipReader.new segfaults — Markus Fischer <redmine@...>
Bug #1629: [Segfault] z = Zlib::GzipReader.new segfaults
4 messages
2009/06/14
[#23850] instance_eval no longer yielding self in ruby 1.9 — apeiros <apeiros@...>
Hi folks
10 messages
2009/06/14
[#23877] Re: instance_eval no longer yielding self in ruby 1.9
— Yusuke ENDOH <mame@...>
2009/06/16
Hi,
[#23879] Re: instance_eval no longer yielding self in ruby 1.9
— apeiros <apeiros@...>
2009/06/16
Am 16.06.2009 um 22:12 schrieb Yusuke ENDOH:
[#23880] Re: instance_eval no longer yielding self in ruby 1.9
— Florian Gilcher <flo@...>
2009/06/16
[#23904] Re: instance_eval no longer yielding self in ruby 1.9
— apeiros <apeiros@...>
2009/06/17
Am 17.06.2009 um 00:01 schrieb Florian Gilcher:
[#23869] [Bug #1640] [PATCH] Documentation for the Rational Class — Run Paint Run Run <redmine@...>
Bug #1640: [PATCH] Documentation for the Rational Class
12 messages
2009/06/16
[#23878] trouble registering and logging in to the issue tracking system — Knutaf H <knutaf@...>
Hi,
5 messages
2009/06/16
[#23883] Merging recent Ruby threading improvements — Joe Damato <ice799@...>
Hi ruby-core and CC'ed friends -
5 messages
2009/06/16
[#23934] [Bug #1661] RegExp mismatch — Adam Carheden <redmine@...>
Bug #1661: RegExp mismatch
6 messages
2009/06/19
[#23950] [Bug #1668] Error installing ruby gems for 1.9.1 on windows vista — Kristian Mandrup <redmine@...>
Bug #1668: Error installing ruby gems for 1.9.1 on windows vista
4 messages
2009/06/20
[#23977] [ANN] meeting log of RubyDeveloperKaigi20090622 — "Yugui (Yuki Sonoda)" <yugui@...>
Hi,
41 messages
2009/06/23
[#23979] Re: [ANN] meeting log of RubyDeveloperKaigi20090622
— Run Paint Run Run <runrun@...>
2009/06/23
Thanks for the update. :-)
[#23984] Re: [ANN] meeting log of RubyDeveloperKaigi20090622
— James Gray <james@...>
2009/06/23
On Jun 23, 2009, at 4:23 AM, Run Paint Run Run wrote:
[#24173] Re: [ANN] meeting log of RubyDeveloperKaigi20090622
— "NARUSE, Yui" <naruse@...>
2009/07/07
Sorry for late response,
[#24174] Re: [ANN] meeting log of RubyDeveloperKaigi20090622
— Luis Lavena <luislavena@...>
2009/07/07
On Tue, Jul 7, 2009 at 12:12 AM, NARUSE, Yui<[email protected]> wrote:
[#24242] Re: [ANN] meeting log of RubyDeveloperKaigi20090622
— Charles Oliver Nutter <headius@...>
2009/07/09
On Mon, Jul 6, 2009 at 10:18 PM, Luis Lavena<[email protected]> wrote:
[#24250] Re: [ANN] meeting log of RubyDeveloperKaigi20090622
— Jörg W Mittag <joergwmittag@...>
2009/07/10
Charles Oliver Nutter wrote:
[#24261] Re: [ANN] meeting log of RubyDeveloperKaigi20090622
— Charles Oliver Nutter <headius@...>
2009/07/11
I agree pretty much across the board. I was actually hoping that
[#24264] Re: [ANN] meeting log of RubyDeveloperKaigi20090622
— "NARUSE, Yui" <naruse@...>
2009/07/11
Charles Oliver Nutter wrote:
[#23995] Re: [ANN] meeting log of RubyDeveloperKaigi20090622
— Jeremy Kemper <jeremy@...>
2009/06/23
2009/6/23 Yugui (Yuki Sonoda) <[email protected]>
[#24106] Re: [ANN] meeting log of RubyDeveloperKaigi20090622
— Charles Oliver Nutter <headius@...>
2009/07/01
2009/6/23 Yugui (Yuki Sonoda) <[email protected]>:
[#24107] Re: [ANN] meeting log of RubyDeveloperKaigi20090622
— Luis Lavena <luislavena@...>
2009/07/01
On Wed, Jul 1, 2009 at 3:20 PM, Charles Oliver
[#23986] possible bug with windows `` they don't set $? — Roger Pack <rogerdpack@...>
Looks like a bug? [1.8 or 1.9]
4 messages
2009/06/23
[#23988] [Bug #1680] URI.encode does not encode '+' (by default) — Xuân Baldauf <redmine@...>
Bug #1680: URI.encode does not encode '+' (by default)
7 messages
2009/06/23
[#23997] [Bug #1681] Integer#chr Should Infer Encoding of Given Codepoint — Run Paint Run Run <redmine@...>
Bug #1681: Integer#chr Should Infer Encoding of Given Codepoint
6 messages
2009/06/23
[#23999] Re: [Bug #1681] Integer#chr Should Infer Encoding of Given Codepoint
— Nobuyoshi Nakada <nobu@...>
2009/06/23
Hi,
[#24001] Re: [Bug #1681] Integer#chr Should Infer Encoding of Given Codepoint
— Run Paint Run Run <runrun@...>
2009/06/24
>> This seems needlessly verbose given that Ruby already knows
[#24007] [Bug #1684] ruby/rubyw.rc still say 1.9.1 — Roger Pack <redmine@...>
Bug #1684: ruby/rubyw.rc still say 1.9.1
4 messages
2009/06/24
[#24010] [Bug #1685] Some windows unicode path issues remain — B Kelly <redmine@...>
Bug #1685: Some windows unicode path issues remain
26 messages
2009/06/24
[#28979] [Bug #1685] Some windows unicode path issues remain
— B Kelly <redmine@...>
2010/03/25
Issue #1685 has been updated by B Kelly.
[#29189] [Bug #1685] Some windows unicode path issues remain
— Yuki Sonoda <redmine@...>
2010/04/01
Issue #1685 has been updated by Yuki Sonoda.
[#29200] Re: [Bug #1685] Some windows unicode path issues remain
— Bill Kelly <billk@...>
2010/04/01
Yuki Sonoda wrote:
[#29892] Re: [Bug #1685] Some windows unicode path issues remain
— Bill Kelly <billk@...>
2010/04/29
Hi,
[#30004] Re: [Bug #1685] Some windows unicode path issues remain
— "U.Nakamura" <usa@...>
2010/05/04
Hello,
[#30012] Re: [Bug #1685] Some windows unicode path issues remain
— Bill Kelly <billk@...>
2010/05/05
U.Nakamura wrote:
[#30013] Re: [Bug #1685] Some windows unicode path issues remain
— "U.Nakamura" <usa@...>
2010/05/05
Hello,
[#30052] Re: [Bug #1685] Some windows unicode path issues remain
— Bill Kelly <billk@...>
2010/05/06
U.Nakamura wrote:
[#30053] Re: [Bug #1685] Some windows unicode path issues remain
— "U.Nakamura" <usa@...>
2010/05/06
Hello,
[#30054] Re: [Bug #1685] Some windows unicode path issues remain
— Bill Kelly <billk@...>
2010/05/06
Hi,
[#30057] Re: [Bug #1685] Some windows unicode path issues remain
— "U.Nakamura" <usa@...>
2010/05/06
Hello,
[#30071] Re: [Bug #1685] Some windows unicode path issues remain
— Bill Kelly <billk@...>
2010/05/06
Hi,
[#30077] Re: [Bug #1685] Some windows unicode path issues remain
— "U.Nakamura" <usa@...>
2010/05/07
Hello,
[#24025] [Bug #1688] Zlib raises a buffer error when inflating some kinds of data — Luis Lavena <redmine@...>
Bug #1688: Zlib raises a buffer error when inflating some kinds of data
5 messages
2009/06/25
[#24034] [Bug #1688] Zlib raises a buffer error when inflating some kinds of data
— Roger Pack <redmine@...>
2009/06/25
Issue #1688 has been updated by Roger Pack.
[#24035] Re: [Bug #1688] Zlib raises a buffer error when inflating some kinds of data
— Luis Lavena <luislavena@...>
2009/06/25
On Thu, Jun 25, 2009 at 10:28 AM, Roger Pack<[email protected]> wrote:
[#24032] [Bug #1690] backticks don't set $? in windows — Roger Pack <redmine@...>
Bug #1690: backticks don't set $? in windows
6 messages
2009/06/25
[#24033] [Bug #1691] ruby --help doesn't display the "skip rubygems" option — Roger Pack <redmine@...>
Bug #1691: ruby --help doesn't display the "skip rubygems" option
5 messages
2009/06/25
[#24050] 1.9.2 Should Pass RubySpec Before Release — Run Paint Run Run <runrun@...>
I humbly suggest that a prerequisite of 1.9.2 being released is that
6 messages
2009/06/26
[#24058] [Bug #1696] http downloads are unuseably slow — Steven Hartland <redmine@...>
Bug #1696: http downloads are unuseably slow
19 messages
2009/06/27
[#24060] [Bug #1696] http downloads are unuseably slow
— Steven Hartland <redmine@...>
2009/06/27
Issue #1696 has been updated by Steven Hartland.
[#24061] Re: [Bug #1696] http downloads are unuseably slow
— "Muhammad A. Ali" <oldmoe@...>
2009/06/27
Net/HTTP in 1.9.2dev is already working as you described with two
[#24081] Re: [Bug #1696] http downloads are unuseably slow
— Tanaka Akira <akr@...>
2009/06/29
In article <[email protected]>,
[#24082] Re: [Bug #1696] http downloads are unuseably slow
— Eero Saynatkari <ruby-ml@...>
2009/06/29
Excerpts from Tanaka Akira's message of Mon Jun 29 21:17:58 +0300 2009:
[#24085] Re: [Bug #1696] http downloads are unuseably slow
— James Gray <james@...>
2009/06/29
On Jun 29, 2009, at 1:38 PM, Eero Saynatkari wrote:
[#24063] [Feature #1697] Object#<=> — Marc-Andre Lafortune <redmine@...>
Feature #1697: Object#<=>
15 messages
2009/06/28
[#24068] [Feature #1697] Object#<=>
— Rick DeNatale <redmine@...>
2009/06/28
Issue #1697 has been updated by Rick DeNatale.
[#24070] Re: [Feature #1697] Object#<=>
— Eero Saynatkari <ruby-ml@...>
2009/06/28
Excerpts from Luiz Angelo Daros de Luca's message of Sun Jun 28 16:22:45 +0300 2009:
[#24069] [ANN] RubyInstaller: Building installers story and news — Luis Lavena <luislavena@...>
Hey guys,
4 messages
2009/06/28
[#24099] [Bug #1708] require 'complex' Causes Unexpected Behaviour — Run Paint Run Run <redmine@...>
Bug #1708: require 'complex' Causes Unexpected Behaviour
8 messages
2009/06/30
[ruby-core:23664] Re: [Bug #1550] String#lstrip! raises RuntimeError on Frozen String Despite Making No Changes
From:
Yukihiro Matsumoto <matz@...>
Date:
2009-06-01 22:55:11 UTC
List:
ruby-core #23664
Hi,
In message "Re: [ruby-core:23663] Re: [Bug #1550] String#lstrip! raises RuntimeError on Frozen String Despite Making No Changes"
on Tue, 2 Jun 2009 07:14:11 +0900, James Gray <[email protected]> writes:
|> I admit the inconsistency. There could be two policies:
|>
|> (a) methods should raise RuntimeError only when actual changes are
|> made, because it should detect changes.
|>
|> (b) methods should eagerly raise RuntimeError when they could
|> possibly make changes, to detect modify attempt to frozen
|> strings (that most likely caused by bugs) earlier.
|>
|> Currently both policies mixed. You've suggested the former, I'd
|> rather prefer the latter. Any opinion?
|
|I really feel (b) is the better choice. The fact that it worked is
|pretty irrelevant. It shouldn't have worked. Either you didn't need
|to call something like strip!() and you can remove it, or you
|sometimes do need to call it and you'll need to change the code not to
|work on frozen data. Either way, you need to change your code and the
|error shows that.
I have investigated the source and the following methods use the
policy (a):
sub/gsub
rstrip
chop
chomp
Other bang methods use the policy (b). I fixed the local copy.
matz.
diff --git a/ChangeLog b/ChangeLog
index 4d0a55e..3d6da7b 100644
--- a/ChangeLog
+++ b/ChangeLog
@@ -1,3 +1,14 @@
+Tue Jun 2 07:44:43 2009 Yukihiro Matsumoto <[email protected]>
+
+ * string.c (rb_str_gsub_bang): modify check at the beginning.
+ [ruby-core:23662] ref [ruby-core:23657]
+
+ * string.c (rb_str_rstrip_bang): ditto. [ruby-core:23657]
+
+ * string.c (rb_str_chop_bang): ditto.
+
+ * string.c (rb_str_chomp_bang): ditto.
+
Mon Jun 1 11:21:29 2009 Nobuyoshi Nakada <[email protected]>
* cont.c (cont_capture, fiber_store): reraise transferred error.
diff --git a/string.c b/string.c
index ef25fa5..74ee2a5 100644
--- a/string.c
+++ b/string.c
@@ -3744,7 +3744,6 @@ str_gsub(int argc, VALUE *argv, VALUE str, int bang)
val = rb_obj_as_string(val);
}
str_mod_check(str, sp, slen);
- if (bang) str_frozen_check(str);
if (val == dest) { /* paranoid check [ruby-dev:24827] */
rb_raise(rb_eRuntimeError, "block should not cheat");
}
@@ -3808,6 +3807,7 @@ str_gsub(int argc, VALUE *argv, VALUE str, int bang)
static VALUE
rb_str_gsub_bang(int argc, VALUE *argv, VALUE str)
{
+ str_modify_keep_cr(str);
return str_gsub(argc, argv, str, 1);
}
@@ -6044,9 +6044,9 @@ chopped_length(VALUE str)
static VALUE
rb_str_chop_bang(VALUE str)
{
+ str_modify_keep_cr(str);
if (RSTRING_LEN(str) > 0) {
long len;
- rb_str_modify(str);
len = chopped_length(str);
STR_SET_LEN(str, len);
RSTRING_PTR(str)[len] = '\0';
@@ -6100,6 +6100,7 @@ rb_str_chomp_bang(int argc, VALUE *argv, VALUE str)
char *p, *pp, *e;
long len, rslen;
+ str_modify_keep_cr(str);
len = RSTRING_LEN(str);
if (len == 0) return Qnil;
p = RSTRING_PTR(str);
@@ -6108,7 +6109,6 @@ rb_str_chomp_bang(int argc, VALUE *argv, VALUE str)
rs = rb_rs;
if (rs == rb_default_rs) {
smart_chomp:
- str_modify_keep_cr(str);
enc = rb_enc_get(str);
if (rb_enc_mbminlen(enc) > 1) {
pp = rb_enc_left_char_head(p, e-rb_enc_mbminlen(enc), e, enc);
@@ -6160,7 +6160,6 @@ rb_str_chomp_bang(int argc, VALUE *argv, VALUE str)
len--;
}
if (len < RSTRING_LEN(str)) {
- str_modify_keep_cr(str);
STR_SET_LEN(str, len);
RSTRING_PTR(str)[len] = '\0';
return str;
@@ -6182,7 +6181,6 @@ rb_str_chomp_bang(int argc, VALUE *argv, VALUE str)
memcmp(RSTRING_PTR(rs), pp, rslen) == 0)) {
if (rb_enc_left_char_head(p, pp, e, enc) != pp)
return Qnil;
- str_modify_keep_cr(str);
if (ENC_CODERANGE(str) != ENC_CODERANGE_7BIT) {
ENC_CODERANGE_CLEAR(str);
}
@@ -6301,6 +6299,7 @@ rb_str_rstrip_bang(VALUE str)
rb_encoding *enc;
char *s, *t, *e;
+ str_modify_keep_cr(str);
enc = STR_ENC_GET(str);
rb_str_check_dummy_enc(enc);
s = RSTRING_PTR(str);
@@ -6324,7 +6323,6 @@ rb_str_rstrip_bang(VALUE str)
if (t < e) {
int len = t-RSTRING_PTR(str);
- str_modify_keep_cr(str);
STR_SET_LEN(str, len);
RSTRING_PTR(str)[len] = '\0';
return str;