[#46105] [ruby-trunk - Feature #6687][Open] Enumerable#with — "merborne (kyo endo)" <redmine@...>

14 messages 2012/07/02

[#46133] [ruby-trunk - Feature #6688][Open] Object#replace — "prijutme4ty (Ilya Vorontsov)" <prijutme4ty@...>

24 messages 2012/07/03

[#46160] [ruby-trunk - Feature #6693][Open] Don't warn for unused variables starting with _ — "marcandre (Marc-Andre Lafortune)" <ruby-core@...>

15 messages 2012/07/04

[#46200] [ruby-trunk - Bug #6702][Open] Date should be either required or not — "rosenfeld (Rodrigo Rosenfeld Rosas)" <rr.rosas@...>

14 messages 2012/07/05

[#46296] [ruby-trunk - Feature #6717][Open] Method like #instance_eval that returns self (like #tap) — "alexeymuranov (Alexey Muranov)" <redmine@...>

10 messages 2012/07/10

[#46320] [ruby-trunk - Feature #6721][Open] Object#yield_self — "alexeymuranov (Alexey Muranov)" <redmine@...>

25 messages 2012/07/11

[#46339] [ruby-trunk - Bug #6724][Open] waaaaaaant! ( — "zenspider (Ryan Davis)" <redmine@...>

11 messages 2012/07/11

[#46377] [ruby-trunk - Feature #6727][Open] Add Array#rest (with implementation) — "duckinator (Nick Markwell)" <nick@...>

25 messages 2012/07/13

[#46492] [ruby-trunk - Feature #6737][Open] Add Hash#read and alias as #[]. — "trans (Thomas Sawyer)" <transfire@...>

12 messages 2012/07/15

[#46500] [ruby-trunk - Feature #6739][Open] One-line rescue statement should support specifying an exception class — Quintus (Marvin Gülker) <sutniuq@...>

22 messages 2012/07/15

[#46562] [ruby-trunk - Feature #6758][Open] Object#sequence — "merborne (kyo endo)" <redmine@...>

19 messages 2012/07/20

[#46574] [ruby-trunk - Feature #6762][Open] Control interrupt timing — "ko1 (Koichi Sasada)" <redmine@...>

39 messages 2012/07/20

[#46641] [ruby-trunk - Bug #6780][Open] cannot compile zlib module, when cross-compiling. — "jinleileiking (lei king)" <jinleileiking@...>

14 messages 2012/07/23

[#46659] [ruby-trunk - Bug #6783][Open] Infinite loop in inspect, not overriding inspect, to_s, and no known circular references. Stepping into inspect in debugger locks it up with 100% CPU. — "garysweaver (Gary Weaver)" <garysweaver@...>

8 messages 2012/07/23

[#46792] [ruby-trunk - Bug #6799][Open] Digest::*.hexdigest returns an ASCII-8BIT String — "Eregon (Benoit Daloze)" <redmine@...>

11 messages 2012/07/26

[#46799] [ruby-trunk - Feature #6801][Open] String#~ for a here document — "merborne (kyo endo)" <redmine@...>

12 messages 2012/07/27

[#46829] [ruby-trunk - Feature #6806][Open] Support functional programming: forbid instance/class variables for ModuleName::method_name, allow for ModuleName.method_name — "alexeymuranov (Alexey Muranov)" <redmine@...>

7 messages 2012/07/28

[#46832] [ruby-trunk - Bug #6807][Open] Can't compile ruby without ruby — "devcurmudgeon (Paul Sherwood)" <storitel@...>

13 messages 2012/07/28

[#46834] [ruby-trunk - Feature #6808][Open] Implicit index for enumerations — "trans (Thomas Sawyer)" <transfire@...>

15 messages 2012/07/28

[#46838] [ruby-trunk - Bug #6810][Open] `module A::B; end` is not equivalent to `module A; module B; end; end` with respect to constant lookup (scope) — "alexeymuranov (Alexey Muranov)" <redmine@...>

17 messages 2012/07/28

[#46896] (Half-baked DRAFT) new `require' framework — SASADA Koichi <ko1@...>

Hi,

22 messages 2012/07/31

[ruby-core:46557] [ruby-trunk - Bug #6753][Open] Comparing Date::Infinity with Date/DateTime

From: "herwinw (Herwin Weststrate)" <herwin@...>
Date: 2012-07-19 09:25:43 UTC
List: ruby-core #46557
Issue #6753 has been reported by herwinw (Herwin Weststrate).

----------------------------------------
Bug #6753: Comparing Date::Infinity with Date/DateTime
https://bugs.ruby-lang.org/issues/6753

Author: herwinw (Herwin Weststrate)
Status: Open
Priority: Normal
Assignee: 
Category: 
Target version: 1.9.3
ruby -v: ruby 1.9.3p0 (2011-10-30 revision 33570) [i686-linux]


Depending on the order you use for comparing, this works or throws an error. A snippet from IRB

irb(main):001:0> require 'date'
=> true
irb(main):002:0> DateTime.now < Date::Infinity.new
=> true
irb(main):003:0> Date::Infinity.new > DateTime.now
ArgumentError: comparison of Date::Infinity with DateTime failed

The same thing happens when using Date instead of DateTime.

The problem arises in Date::Infinity#<=>(other). This method checks if the other is a Date::Infinity (it is not) or a Numeric (it is not). It then falls back to the generic code, which calls other.coerce. Since both instances of DateTime and Date don't have a coerce method this fails.

I've fixed the problem here by adding this line to Date::Infinity#<=>(other)

  when DateTime, Date; return d

This is not optimal, because when you'll try to compare an instance created with Date::Infinity.new(0), it will always return 0 when comparing with a Date(Time), which means any Date(Time) will be equal to Date::Infinity.new(0). Then again, I don't see the use case where you would initialize the Date::Infinity with a value of 0, and the same problem happens when you're comparing it with a Numeric.

irb(main):006:0> Date::Infinity.new(0) == 4
=> true

I'm not really familiar with the background of the coerce method, but relying on the coerce of a given parameter seems a little bit weird to me. There is no check on the type of the parameter (except it is not Date::Infinity and not numeric) which means the coerce method can be anything (if it exists).


-- 
http://bugs.ruby-lang.org/

In This Thread

Prev Next