[#61424] [REJECT?] xmalloc/xfree: reduce atomic ops w/ thread-locals — Eric Wong <normalperson@...>

I'm unsure about this. I _hate_ the extra branches this adds;

13 messages 2014/03/12

[ruby-core:61489] Re: [ruby-trunk - Feature #9634] [Open] [PATCH]Symbol GC

From: Eric Wong <normalperson@...>
Date: 2014-03-14 06:34:20 UTC
List: ruby-core #61489
Cool!  I benchmarked your original version and it didn't notice obvious
regressions.

I noticed rb_check_id_without_pindown still takes a volatile arg.  Is
this for GC-safety?  Can we encourage RB_GC_GUARD instead for new APIs?
volatile is not always enough, and tends to generate bad code.  I
realize this was probably for consistency with the old rb_check_id
function.

In This Thread

Prev Next