ruby-dev

遠藤です。

2008/07/30 7:33 Tanaka Akira <[email protected]>:
> In article <[email protected]>,
>  "Yusuke ENDOH" <[email protected]> writes:
>
>> 2008/07/25 2:41 NARUSE, Yui <[email protected]>:
>>> 行単位の restart は ISO-2022-JP や UTF-7 は可能な気がします。
>>> つまるところ、decode しなくても改行の認識が可能な encoding については、
>>> gets をサポートする方向です。
>>
>> test_terminator_stateful_conversion(TestIO_M17N) のように、gets に
>> デリミタを指定するようなのも、サポート対象外ですよね。たぶん。
>
> なんでサポート対象外なんですか?

改行の認識の話ばっかりだったので、そういう前提かと誤読してました。


ちょっと UTF-7 を調べてみたんですが、RFC 2152 によると任意の文字を
BASE64 でエンコードしてもいいようです。

$ echo foo+AAo-bar | iconv -f=UTF-7 -t=UTF-8 | od -c
0000000   f   o   o  \n   b   a   r  \n
0000010

これでは改行文字が認識できない可能性があるので、UTF-7 に対する
gets は一切禁止しなければならないと思います。
それならいっそ dummy encoding に対する gets はすべて禁止しちゃえ、
というのが私の意見です。

が、どうしても ISO-2022-JP で gets したいという需要が無視できない
のでしたら、gets で ISO-2022-JP だけ特別扱いするのはどうでしょう。
IO が stateful encoding をサポートする日までの workaround です。

ESC 以外の制御文字だけからなるデリミタだけは通すようにしました。

Index: io.c
===================================================================
--- io.c	(revision 18264)
+++ io.c	(working copy)
@@ -1956,8 +1956,23 @@

     GetOpenFile(io, fptr);
     rb_io_check_readable(fptr);
-    if (rb_enc_dummy_p(io_input_encoding(fptr)) && rs != rb_default_rs) {
-	rb_raise(rb_eNotImpError, "gets with delimiter against dummy
encoding is not currently supported");
+    /* FIXME! please support stateful encoding */
+    if (rb_enc_dummy_p(io_input_encoding(fptr))) {
+	const char *name = rb_enc_name(io_input_encoding(fptr));
+	if ((strcmp(name, "ISO-2022-JP")  == 0 || strcmp(name, "ISO2022-JP")  == 0 ||
+	     strcmp(name, "ISO-2022-JP2") == 0 || strcmp(name, "ISO2022-JP2") == 0) &&
+	    !NIL_P(rs) && rs != rb_default_rs) {
+	    int i;
+	    for (i = 0; i < RSTRING_LEN(rs); i++) {
+		char c = RSTRING_PTR(rs)[i];
+		if (c == 0x1b || 0x20 <= c) {
+		    rb_raise(rb_eNotImpError, "gets against dummy encoding is not
currently supported");
+		}
+	    }
+	}
+	else {
+	    rb_raise(rb_eNotImpError, "gets against dummy encoding is not
currently supported");
+	}
     }
     if (NIL_P(rs)) {
 	str = read_all(fptr, 0, Qnil);

-- 
Yusuke ENDOH <[email protected]>

Thread

Prev Next

In This Thread

Prev Next

[#35290] WeakRef#inspect について — keiju@... (Keiju ISHITSUKA)

[#35308] [Ruby 1.8 - Bug #214] (Open) $0に長い文字列を入れるとpsの出力に環境変数らしきものが出てくる — takeru sasaki <redmine@...>

[#35318] rb_during_gc — Masaki Suketa <masaki.suketa@...>

[#35333] [Ruby 1.8 - Bug #221] (Open) Net::SMTPでSMTPのHELO/EHLOにデフォルトで不正なホスト名を使用 — Anonymous <redmine@...>

[#35350] Re: [ruby-core:17491] [Ruby 1.8.7 - Bug #213] (Open) Different ERB behavior across versions — Urabe Shyouhei <shyouhei@...>

[#35355] リリース前ToDoリスト — Yukihiro Matsumoto <matz@...>

[#35369] fiber もどき for 1.8.x — "IWAMURO Motonori" <deenheart+ruby@...>

[#35372] patch for ruby-core:17472 — wanabe <s.wanabe@...>

[#35375] Re: [ruby-cvs:25121] Ruby:r17902 (ruby_1_8_6): * re.c (rb_reg_search): need to free allocated buffer in re_register. [ruby-core:17518] — Urabe Shyouhei <shyouhei@...>

[#35379] [Feature:1.9] rb_scan_args() for keyword arguments — Nobuyoshi Nakada <nobu@...>

[#35389] Re: [ruby-cvs:25164] Ruby:r17945 (trunk, ruby_1_8): * string.c (rb_str_succ): limit carrying in an alphanumeric region if — Yukihiro Matsumoto <matz@...>

[#35390] Re: [ruby-cvs:25170] Ruby:r17951 (trunk): * dir.c (Next): use rb_enc_precise_mbclen. — Tanaka Akira <akr@...>

[#35392] [Bug: 1.9] Block level with binding — SASADA Koichi <ko1@...>

[#35393] Ruby 1.9.1に含まれる機能について — "Yugui (Yuki Sonoda)" <yugui@...>

[#35395] Re: Ruby:r17955 (trunk): * lib/debug.rb, lib/profile.rb: fix to use RubyVM. — Kazuhiro NISHIYAMA <zn@...>

[#35396] cc always picks ruby/ruby.h on OS X — "Akinori MUSHA" <knu@...>

[#35400] [Ruby 1.9 - Bug #245] (Open) IPAddr#to_range raise ArgumentError — okkez _ <redmine@...>

[#35404] ruby_1_8_6/ruby_1_8_7ブランチのメンテナンスポリシーについて — "Shugo Maeda" <shugo@...>

[#35409] [Ruby 1.9 - Bug #250] (Open) tr で 全角数字が変換されません。 — Anonymous <redmine@...>

[#35410] [Ruby 1.9 - Bug #250] (Closed) tr で 全角数字が変換されません。 — Yui NARUSE <redmine@...>

[#35414] [Bug:1.9] $? is not thread scope — Tanaka Akira <akr@...>

[#35420] Re: [ruby-cvs:25212] Ruby:r17993 (trunk): * test/ruby/envutil.rb (assert_normal_exit): finish writing script — Tanaka Akira <akr@...>

[#35426] cgiのテストについて — Fujioka <fuj@...>

[#35441] Re: [ruby-core:17623] Re: We'll release 1.8.6/1.8.7 this Friday — Urabe Shyouhei <shyouhei@...>

[#35444] [Ruby 1.9 - Feature #17] (Closed) deadlock detection for 1.9 — Yusuke Endoh <redmine@...>

[#35446] [Bug:trunk] Thread#kill cannot break BLOCKING_REGION() on windows — "U.Nakamura" <usa@...>

[#35450] [BUG] cfp consistency error in Win32OLE — Masaki Suketa <masaki.suketa@...>

[#35458] make profiler for gc — authorNari <authornari@...>

[#35466] [Ruby 1.8 - Bug #269] (Open) OptionParser#environment requires shellwords — Takashi Tamura <redmine@...>

[#35471] [Bug: 1.9] lazy timer thraed creation — SASADA Koichi <ko1@...>

[#35480] 1.9.1 featureと1.9.0-3リリースプラン — "Yugui (Yuki Sonoda)" <yugui@...>

[#35481] [Ruby 1.9 - Bug #272] (Open) test_chdir failed when Dir.tmpdir is symlink — Kazuhiro NISHIYAMA <redmine@...>

[#35483] pack('i')の挙動...はたして何が期待されているのか — Urabe Shyouhei <shyouhei@...>

[#35484] Re: [ruby-core:17739] [Ruby 1.9 - Bug #256] (Open) defined?(Gem::RubyGemsVersion) behaves strange — wanabe <s.wanabe@...>

[#35489] [Ruby 1.8 - Bug #274] (Open) typo in net/smtp — Masao Takaku <redmine@...>

[#35533] [Bug:1.9] trap("INT", "p 1") causes ArgumentError — Tanaka Akira <akr@...>

[#35542] [Bug:1.9] sleep and Thread#run — Tanaka Akira <akr@...>

[#35545] Test::Unit -> miniunit — Kouhei Sutou <kou@...>

[#35554] [Ruby 1.9 - Bug #6] sprintf() of %f on Windows(MSVCRT) — Usaku NAKAMURA <redmine@...>

[#35555] [Ruby 1.9 - Bug #282] (Open) failure of test_asctime(TestTime) on mswin32 — Usaku NAKAMURA <redmine@...>

[#35566] rdoc defines Hash#method_missing — "Yusuke ENDOH" <mame@...>

[#35578] [Bug:1.9] context switch may occur during freeing io — "Yusuke ENDOH" <mame@...>

[#35596] ruby1.9 -n/-p and END{} — Nobuhiro IMAI <nov@...>

[#35597] [request]C APIの拡張 — "Goro Fuji" <g.psy.va@...>

[#35599] Readline::HISTORYの特異メソッドのrdocの書き方について — Takao Kouji <[email protected]>

[#35605] Generator/Fiber (Re: Re: fiber もどき for 1.8.x) — "IWAMURO Motonori" <deenheart+ruby@...>

[#35610] SEGV by STDIN.gets(0,0) — Tanaka Akira <akr@...>

[#35615] more descriptive aliases of rb_str_new[2-5] (Re: [request]C APIの拡張) — Nobuyoshi Nakada <nobu@...>

[#35617] rb_filesystem_encoding on Unix — Tanaka Akira <akr@...>

[#35620] non-locale filename encoding — Tanaka Akira <akr@...>

[#35633] [Bug:1.9] File.grpowned?のテスト — Kazuhiro NISHIYAMA <zn@...>

[#35636] [Ruby 1.9 - Bug #354] (Open) Test failure test/ruby/test_transcode.rb — Martin Dürst <redmine@...>

[#35637] [Ruby 1.9 - Bug #355] (Open) ext/opensslのmakeが通らない — Anonymous <redmine@...>

[#35638] [Ruby 1.9 - Bug #356] (Open) test_flush(TestIONonblock): Errno::EBADF: Bad file descriptor — Kazuhiro NISHIYAMA <redmine@...>

[#35640] [Ruby 1.9 - Bug #354] (Assigned) Test failure test/ruby/test_transcode.rb — Yui NARUSE <redmine@...>

[#35641] [Ruby 1.9 - Bug #354] Test failure test/ruby/test_transcode.rb — Yui NARUSE <redmine@...>

[#35646] [Bug:1.9] Rinda has a race condition — "Yusuke ENDOH" <mame@...>

[#35647] [bug] cygwin: Windows styleのload pathが無効 — Nobuyoshi Nakada <nobu@...>

[#35648] [Bug:1.9] MingwでIO#dupがブロックする — wanabe <s.wanabe@...>

[#35649] PENDINGS.rb (Was: Re: [Ruby 1.9 - Bug #354] (Assigned) Test failure test/ruby/test_transcode.rb) — "Yusuke ENDOH" <mame@...>

[#35655] [Ruby 1.9 - Bug #354] (Closed) Test failure test/ruby/test_transcode.rb — Martin Dürst <redmine@...>

[#35657] [Ruby 1.9 - Bug #356] test_flush(TestIONonblock): Errno::EBADF: Bad file descriptor — Kazuhiro NISHIYAMA <redmine@...>

[#35666] [Ruby 1.8 - Bug #367] (Open) ruby_1_8のrssで3E — Kazuhiro NISHIYAMA <redmine@...>

[#35669] [Ruby 1.9 - Bug #368] (Open) 境界における Math.atanh 等の動作 — Yui NARUSE <redmine@...>

[#35673] fail to compile extension library in Cygwin (trunk r18249) — Masaki Suketa <masaki.suketa@...>

[#35680] char_casecmp in dir.c — Tanaka Akira <akr@...>

[#35681] [Ruby 1.9 - Bug #369] (Open) Ruby 1.9.0-3で R — Akira Matsuda <redmine@...>

[#35682] [Ruby 1.9 - Bug #369] Ruby 1.9.0-3で R — Akira Matsuda <redmine@...>

[#35683] [Ruby 1.8 - Bug #367] (Closed) ruby_1_8のrssで3E — Kouhei Sutou <redmine@...>

[#35684] [Ruby 1.9 - Bug #369] Ruby 1.9.0-3で R — Akira Matsuda <redmine@...>

[#35685] encoding of Dir#path — Tanaka Akira <akr@...>

[#35704] str.encode("utf-32le", :invalid=>:replace) — Tanaka Akira <akr@...>

[#35705] "\x80".force_encoding("utf-8").encode("utf-32be",:invalid=>:replace) — Tanaka Akira <akr@...>

[#35706] rdoc コマンドで定数の説明を処理できない — Takao Kouji <[email protected]>

[ruby-dev:35695] Re: PENDINGS.rb (Was: Re: [Ruby 1.9 - Bug #354] (Assigned) Test failure test/ruby/test_transcode.rb)

Thread

In This Thread

[#35409] [Ruby 1.9 - Bug #250] (Open) tr で全角数字が変換されません。 — Anonymous <redmine@...>

[#35410] [Ruby 1.9 - Bug #250] (Closed) tr で全角数字が変換されません。 — Yui NARUSE <redmine@...>