Add a CallbackModeDiscrete property to AnimationMixer to handle the case of blending Continuous and Discrete tracks#86629
Merged
Conversation
03d7911 to
61a7f7a
Compare
61a7f7a to
d922473
Compare
27953ca to
1f3016e
Compare
1f3016e to
ce3202f
Compare
Member
Author
|
Fixed a bug where However, the old Nearest interpolation is not unreasonable, so for now this is only used when converted from Discrete by |
6c2e56c to
5c09425
Compare
5c09425 to
d075566
Compare
74cc871 to
489354c
Compare
489354c to
fee827b
Compare
lyuma
approved these changes
Feb 17, 2024
lyuma
left a comment
Contributor
There was a problem hiding this comment.
After Tokage explained it to me, I understand what this is fixing and it makes sense.
I do think users are going to be confused, so I'm suggesting some documentation changes.
fee827b to
4b84ddb
Compare
AThousandShips
approved these changes
Feb 17, 2024
4b84ddb to
bc20fdf
Compare
Member
|
Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
CallbackModeDiscretetoAnimationMixerand improve the setting method forUpdateModeinAnimationTrackEditorgodot-proposals#8512As noted in godotengine/godot-proposals#8512, this allows user control how the Discrete/Continuous tracks are handled when blending occurs. See also #86630.