Refactor with_sudo_pty to BaseConnection (no-op) and SshConnection.

[zenspider]

Fixes current red on master.

[chef-expeditor]

Hello zenspider! Thanks for the pull request!

Here is what will happen next:

1. Your PR will be reviewed by the maintainers.
2. Possible Outcomes
   a. If everything looks good, one of them will approve it, and your PR will be merged.
   b. The maintainer may request follow-on work (e.g. code fix, linting, etc). We would encourage you to address this work in 2-3 business days to keep the conversation going and to get your contribution in sooner.
   c. Cases exist where a PR is neither aligned to Chef InSpec's product roadmap, or something the team can own or maintain long-term. In these cases, the maintainer will provide justification and close out the PR.

Thank you for contributing!

[qlty-cloud-legacy]

Code Climate has analyzed commit 8867db9 and detected 0 issues on this pull request.

View more on Code Climate.

[tas50]

This seems like a solid step in the right direction