Skip to content

BUG: Fix series rename called with str altering name rather index (GH17407) #17654

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
TomAugspurger merged 8 commits into from
Sep 30, 2017
Merged

BUG: Fix series rename called with str altering name rather index (GH17407) #17654

Changes from 1 commit
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
3e3e925
BUG: Fix series rename called with str altering the name. GH17407
huashuai Sep 24, 2017
99300dd
add whatsnew for the fix for #17407
huashuai Sep 24, 2017
b9ee088
Fix typo in whatsnew
huashuai Sep 24, 2017
4996e76
remove whitespace
huashuai Sep 24, 2017
41436c2
Update code after @jreback's comments
huashuai Sep 24, 2017
f97c9bc
Change `or` to `and` for checking iterable
huashuai Sep 25, 2017
45d30d4
Only check against Iterable in is_list_like and add test for `str`
huashuai Sep 26, 2017
a1f9565
Update v0.21.0.txt
TomAugspurger Sep 30, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
remove whitespace
  • Loading branch information
@huashuai
huashuai committed Sep 29, 2017
commit 4996e764fb0adbd5c77574eb3cb60f19c0fafba3
2 changes: 1 addition & 1 deletion pandas/tests/series/test_indexing.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2189,7 +2189,7 @@ def test_reindex_fill_value(self):
assert_series_equal(result, expected)

def test_rename(self):

# GH 17407
s = Series(range(1, 6), index=pd.Index(range(2, 7), name='IntIndex'))
result = s.rename(str)
Expand Down