Skip to content

BUG: Fix series rename called with str altering name rather index (GH17407) #17654

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
TomAugspurger merged 8 commits into from
Sep 30, 2017
Merged

BUG: Fix series rename called with str altering name rather index (GH17407) #17654

Changes from 1 commit
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
3e3e925
BUG: Fix series rename called with str altering the name. GH17407
huashuai Sep 24, 2017
99300dd
add whatsnew for the fix for #17407
huashuai Sep 24, 2017
b9ee088
Fix typo in whatsnew
huashuai Sep 24, 2017
4996e76
remove whitespace
huashuai Sep 24, 2017
41436c2
Update code after @jreback's comments
huashuai Sep 24, 2017
f97c9bc
Change `or` to `and` for checking iterable
huashuai Sep 25, 2017
45d30d4
Only check against Iterable in is_list_like and add test for `str`
huashuai Sep 26, 2017
a1f9565
Update v0.21.0.txt
TomAugspurger Sep 30, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Fix typo in whatsnew
  • Loading branch information
@huashuai
huashuai committed Sep 29, 2017
commit b9ee0880092b58f88de8701084d7f9bb87f8b187
3 changes: 2 additions & 1 deletion doc/source/whatsnew/v0.21.0.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -588,8 +588,9 @@ Indexing
- Bug in ``CategoricalIndex`` reindexing in which specified indices containing duplicates were not being respected (:issue:`17323`)
- Bug in intersection of ``RangeIndex`` with negative step (:issue:`17296`)
- Bug in ``IntervalIndex`` where performing a scalar lookup fails for included right endpoints of non-overlapping monotonic decreasing indexes (:issue:`16417`, :issue:`17271`)
<<<<<<< 99300ddcc636c859a02b3010ee379d1adbd1678e
- Bug in :meth:`DataFrame.first_valid_index` and :meth:`DataFrame.last_valid_index` when no valid entry (:issue:`17400`)
- Bug in ``Series.rename`` when called with `str` will alter name of series rather than index of series. (:issue:`17407`)
- Bug in ``Series.rename`` when called with `str` alters name of series rather than index of series. (:issue:`17407`)
Copy link
Contributor

@jreback jreback Sep 24, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

called with a callable


I/O
^^^
Expand Down