[#99868] [Ruby master Bug#17144] Tempfile.open { ... } does not unlink the file — eregontp@...
Issue #17144 has been reported by Eregon (Benoit Daloze).
15 messages
2020/09/03
[ruby-core:100078] [Ruby master Bug#16455] coroutine ucontext uses deprecated POSIX getcontext/swapcontext/makecontext, absent in musl and uclibc
From:
aladjev.andrew@...
Date:
2020-09-22 23:08:38 UTC
List:
ruby-core #100078
Issue #16455 has been updated by puchuu (Andrew Aladjev). ioquatix (Samuel Williams) wrote in #note-7: > It is fixed: https://github.com/ruby/ruby/pull/2995 Hello, you have provided good fix but it is related to armv7 only. For example: aarch64-gentoo-linux-musl and aarch64_be-gentoo-linux-musl are valid CHOSTS, but first one works fine, second one fails. First one is using "rb_cv_coroutine=arm64", second one is using default "rb_cv_coroutine=ucontext". Same thing will be true for s390x, other arches: it will try to use default broken (for musl) "rb_cv_coroutine=ucontext". @luizluca have provided right fix - it works perfect. https://github.com/ruby/ruby/pull/3567 ---------------------------------------- Bug #16455: coroutine ucontext uses deprecated POSIX getcontext/swapcontext/makecontext, absent in musl and uclibc https://bugs.ruby-lang.org/issues/16455#change-87635 * Author: luizluca (Luiz Angelo Daros de Luca) * Status: Closed * Priority: Normal * Assignee: ioquatix (Samuel Williams) * Target version: 2.8 * ruby -v: ruby 2.7.0p0 (2019-12-25 revision 647ee6f091) * Backport: 2.5: UNKNOWN, 2.6: UNKNOWN ---------------------------------------- Hello, While building ruby 2.7.0 for mips with musl, it fails: ``` linking miniruby /home/luizluca/prog-local/openwrt/trunk/staging_dir/toolchain-mips_24kc_gcc-8.3.0_musl/lib/gcc/mips-openwrt-linux-musl/8.3.0/../../../../mips-openwrt-linux-musl/bin/ld: cont.o: in function `coroutine_initialize_main': cont.c:(.text+0x36c): undefined reference to `getcontext' /home/luizluca/prog-local/openwrt/trunk/staging_dir/toolchain-mips_24kc_gcc-8.3.0_musl/lib/gcc/mips-openwrt-linux-musl/8.3.0/../../../../mips-openwrt-linux-musl/bin/ld: cont.o: in function `fiber_setcontext': cont.c:(.text+0xde6): undefined reference to `swapcontext' /home/luizluca/prog-local/openwrt/trunk/staging_dir/toolchain-mips_24kc_gcc-8.3.0_musl/lib/gcc/mips-openwrt -linux-musl/8.3.0/../../../../mips-openwrt-linux-musl/bin/ld: cont.o: in function `fiber_switch': cont.c:(.text+0x16b8): undefined reference to `makecontext' collect2: error: ld returned 1 exit status make[3]: *** [Makefile:271: miniruby] Error 1 ``` It seems that now ruby either uses native ASM code or ucontext for coroutine. Both are unavailable in my crossbuild. It was building and running with 2.6.x: ``` configure:25935: checking native coroutine implementation for mips-linux-gnu configure:25976: result: no ``` With 2.7.0: ``` configure:26536: checking native coroutine implementation for mips-linux-gnu configure:26601: result: ucontext ``` I tried to disable it with --without-coroutine, --with-out-coroutine and --with-coroutine=no, but it is innocuous or try to use a "no" implementation. It looks like this introduced the change https://github.com/ruby/ruby/commit/7291fef55c90b9ab6b3c22018b16972861b98c9d And musl might never fix it: https://wiki.musl-libc.org/open-issues.html -- https://bugs.ruby-lang.org/ Unsubscribe: <mailto:[email protected]?subject=unsubscribe> <http://lists.ruby-lang.org/cgi-bin/mailman/options/ruby-core>