[#99868] [Ruby master Bug#17144] Tempfile.open { ... } does not unlink the file — eregontp@...
Issue #17144 has been reported by Eregon (Benoit Daloze).
15 messages
2020/09/03
[ruby-core:100082] [Ruby master Feature#17143] Improve support for warning categories
From:
merch-redmine@...
Date:
2020-09-23 05:35:38 UTC
List:
ruby-core #100082
Issue #17143 has been updated by jeremyevans0 (Jeremy Evans).
ko1 (Koichi Sasada) wrote in #note-1:
> Let me clear the proposal. Your PR seems to allow any categories (and any class of object). Is it intentional?
Allowing arbitrary categories is intentional. We probably should restrict the category to be a symbol. The C-API already does this (`rb_category_warn{,ing}` accept `const char *` and convert to symbol), so it would only need to be made for `Kernel#warn` (raising TypeError if `:category` is not a Symbol?). That's a simple change, and I'll try to make it tomorrow, before the developer meeting.
I'm fine with changing the implementation to limit the categories to specific categories and not allow arbitrary categories, if that is what is decided at the developer meeting. That reduces flexibility, but also reduces the chance of a typo resulting in a category being missed. Allowing arbitrary categories has the advantage that users can define their own categories of warnings and filter on them.
----------------------------------------
Feature #17143: Improve support for warning categories
https://bugs.ruby-lang.org/issues/17143#change-87639
* Author: jeremyevans0 (Jeremy Evans)
* Status: Open
* Priority: Normal
----------------------------------------
Support was recently added for Warning.warn to accept a `category` keyword. However, the initial implementation was limited to having `rb_warn_deprecated` and `rb_warn_deprecated_to_remove` use the `:deprecated` value for the `category` keyword.
It doesn't make sense to me to have a `category` keyword if it is only used for deprecation, so I propose we extend the support so that `Kernel#warn` accepts a category keyword (for Ruby-level warnings) and `rb_category_warn` and `rb_category_warning` functions be added to the C-API (for C-level warnings). I also propose that we change existing `rb_warn` and `rb_warning` calls to `rb_category_warn` and `rb_category_warning`, so that all warnings issued by core Ruby are issued with an appropriate category.
I have implemented support for this in a pull request: https://github.com/ruby/ruby/pull/3508
--
https://bugs.ruby-lang.org/
Unsubscribe: <mailto:[email protected]?subject=unsubscribe>
<http://lists.ruby-lang.org/cgi-bin/mailman/options/ruby-core>