[#67346] Future of test suites for Ruby — Charles Oliver Nutter <headius@...>

I'll try to be brief so we can discuss all this. tl;dr: RubySpec is

19 messages 2015/01/05

[ruby-core:67683] [ruby-trunk - Bug #10733] Time.httpdate raises ArgumentError when DateTime.now.httpdate is provided as input

From: leif.eriksen.au@...
Date: 2015-01-19 09:00:22 UTC
List: ruby-core #67683
Issue #10733 has been updated by Leif Eriksen.


This is a tricky one. It is a spooky interaction when calling Time.httpdate with an US-ASCII encoding _after_ calling Time.httpdate with an UTF-8 encoding.

If you just pass the result of DateTime.now.httpdate (which has a US-ASCII encoding), by itself, it works fine.

The space chars in the US-ASCII and UTF-8 strings are identical as \x20 chars, which is what the regex wants.

I can 'fix' the issue by replacing the \x20's in the regexen with \s, but \s has different semantics, it means a space-like char
* space character
* tab character
* carriage return character
* new line character
* vertical tab character
* form feed character

And most of those mean the regex will not limit itself to matching RFC2616-compliant times stamps.

I suspect something is getting upset in the Regexp library, but how to trace it I dont know....yet. I will try to move out of the Time/DateTime libraries and just work with a regex that will be fed different encodings.

----------------------------------------
Bug #10733: Time.httpdate raises ArgumentError when DateTime.now.httpdate is provided as input
https://bugs.ruby-lang.org/issues/10733#change-51102

* Author: Maarten Claes
* Status: Open
* Priority: Normal
* Assignee: 
* ruby -v: ruby 2.2.0p0 (2014-12-25 revision 49005) [x86_64-darwin14]
* Backport: 2.0.0: UNKNOWN, 2.1: UNKNOWN, 2.2: UNKNOWN
----------------------------------------
An irb session demonstrating the bug:

```
irb(main):001:0> require 'time'
=> true
irb(main):002:0> Time.httpdate("Mon, 12 Jan 2015 12:04:15 GMT")
=> 2015-01-12 12:04:15 UTC
irb(main):003:0> DateTime.now.httpdate.to_s
=> "Mon, 12 Jan 2015 12:04:56 GMT"
irb(main):004:0> Time.httpdate(DateTime.now.httpdate.to_s)
ArgumentError: not RFC 2616 compliant date: "Mon, 12 Jan 2015 12:05:08 GMT"
        from /Users/mcls/.rbenv/versions/2.2.0/lib/ruby/2.2.0/time.rb:544:in `httpdate'
        from (irb):4
        from /Users/mcls/.rbenv/versions/2.2.0/bin/irb:11:in `<main>'
```

To reproduce:
```
require 'time'
Time.httpdate("Mon, 12 Jan 2015 12:04:15 GMT") # works
Time.httpdate(DateTime.now.httpdate.to_s) # => ArgumentError
```

It seems that this only occurs on 2.2.0. (Tested on 2.1.5 and it works fine)



-- 
https://bugs.ruby-lang.org/

In This Thread

Prev Next