[ruby-core:89296] [Ruby trunk Bug#15206] require_relative in std_lib

From: Greg.mpls@...
Date: 2018-10-06 15:31:53 UTC
List: ruby-core #89296
Issue #15206 has been updated by MSP-Greg (Greg L).


The Appveyor run on the PR passed.

Appveyor testing has been intermittently failing.  With parallel/multi testing (test-all and/or test-spec), there can be a lot more files being checked and possibly loaded.  Considering more than one CI VM may be exist on a system, and they may share drives, anything that lowers disk I/O is good.

----------------------------------------
Bug #15206: require_relative in std_lib
https://bugs.ruby-lang.org/issues/15206#change-74329

* Author: marcandre (Marc-Andre Lafortune)
* Status: Open
* Priority: Normal
* Assignee: 
* Target version: 
* ruby -v: 
* Backport: 2.3: UNKNOWN, 2.4: UNKNOWN, 2.5: UNKNOWN
----------------------------------------
I noticed that there are some `require` for internal files in `lib/`. Ideally, they would be using `require_relative` instead. This is faster and more explicit.

Note: `require_relative` had a potential issue with symlinks that was fixed in 2.5, so libraries that might be loaded from earlier Ruby, like `rubygems`, can not yet be updated.

I've [created a PR](https://github.com/ruby/ruby/pull/1976) and would like to know if there are comments / objections / things I'm missing.



-- 
https://bugs.ruby-lang.org/

Unsubscribe: <mailto:[email protected]?subject=unsubscribe>
<http://lists.ruby-lang.org/cgi-bin/mailman/options/ruby-core>

In This Thread

Prev Next