ruby-core

Issue #15239 has been updated by MSP-Greg (Greg L).


@k0kubun & @suke

When I did the patch, I saw no reason to have non Windows builds requiring the classes.rb file if they weren't using it.  Hence, for many of the files in the patch, the only change is to move the `
require_relative '../fixtures/classes'` staement inside of the `platform_is :windows do` block.  As mentioned above, without that...

----------------------------------------
Misc #15239: [patch] test-spec win32ole
https://bugs.ruby-lang.org/issues/15239#change-74630

* Author: MSP-Greg (Greg L)
* Status: Open
* Priority: Normal
* Assignee: suke (Masaki Suketa)
----------------------------------------
Some of the current Win32OLE spec tests use the InternetExplorer control.  This control is not available on Azure pipelines. Attached patch changes to use the MSXML control, adds a guard for it, and also does some refactoring to lower requires when not run under Windows, etc.  Also, since the MSXML object is quite a bit 'smaller' than InternetExplorer, tests run faster.

Passed in my fork at https://ci.appveyor.com/project/MSP-Greg/ruby/builds/19663145

Note also that since there have been recent commits stabilizing the spec suite, the above build job changed the mswin spec tests to run parallel, and they passed.  The change from serial to parallel is not included in the patches.  It is a separate commit in the branch on my fork.

GitHub patch is at:
https://github.com/MSP-Greg/ruby/commit/d1daf9a66f491abfac5e84a50f152505baa1ccac.patch


---Files--------------------------------
spec_win32ole.patch (25.8 KB)


-- 
https://bugs.ruby-lang.org/

Unsubscribe: <mailto:[email protected]?subject=unsubscribe>
<http://lists.ruby-lang.org/cgi-bin/mailman/options/ruby-core>