[#35599] Proc#== behaviour on 1.8.7 and 1.9.2 — Adam Prescott <adam@...>
I've encountered a problem when using Proc#== (with both lambdas and
5 messages
2011/04/01
[#35613] [Ruby 1.9 - Feature #4539][Assigned] Array#zip_with — Yui NARUSE <redmine@...>
11 messages
2011/04/05
[#35617] Re: [Ruby 1.9 - Feature #4539][Assigned] Array#zip_with
— Benoit Daloze <eregontp@...>
2011/04/05
> http://redmine.ruby-lang.org/issues/4539
[#35673] Re: [Ruby 1.9 - Feature #4539][Assigned] Array#zip_with
— Kenta Murata <muraken@...>
2011/04/09
Hi,
[#35618] Redmine issues — Benoit Daloze <eregontp@...>
Hello,
6 messages
2011/04/05
[#35621] [Ruby 1.9 - Bug #4555][Open] [PATCH] ext/socket/init.c: rsock_connect retries on interrupt — Eric Wong <normalperson@...>
7 messages
2011/04/05
[#35708] [Ruby 1.9 - Bug #4555] [PATCH] ext/socket/init.c: rsock_connect retries on interrupt
— redmine@...
2011/04/11
[#35629] [Ruby 1.9 - Bug #4473] Calling return within begin still executes else — Mayank Kohaley <redmine@...>
4 messages
2011/04/06
[#35631] [Ruby 1.9 - Bug #4558][Open] TestSocket#test_closed_read fails after r31230 — Tomoyuki Chikanaga <redmine@...>
23 messages
2011/04/06
[#35641] Re: [Ruby 1.9 - Bug #4558][Open] TestSocket#test_closed_read fails after r31230
— KOSAKI Motohiro <kosaki.motohiro@...>
2011/04/07
> ----------------------------------------
[#35647] Re: [Ruby 1.9 - Bug #4558][Open] TestSocket#test_closed_read fails after r31230
— Eric Wong <normalperson@...>
2011/04/07
KOSAKI Motohiro <[email protected]> wrote:
[#35665] [Ruby 1.9 - Bug #4558] TestSocket#test_closed_read fails after r31230
— Tomoyuki Chikanaga <redmine@...>
2011/04/09
[#35669] Re: [Ruby 1.9 - Bug #4558] TestSocket#test_closed_read fails after r31230
— Eric Wong <normalperson@...>
2011/04/09
Tomoyuki Chikanaga <[email protected]> wrote:
[#35715] [Ruby 1.9 - Bug #4558][Assigned] TestSocket#test_closed_read fails after r31230
— redmine@...
2011/04/12
[#35716] [Ruby 1.9 - Bug #4558] TestSocket#test_closed_read fails after r31230
— redmine@...
2011/04/12
[#35726] Re: [Ruby 1.9 - Bug #4558] TestSocket#test_closed_read fails after r31230
— KOSAKI Motohiro <kosaki.motohiro@...>
2011/04/12
> Issue #4558 has been updated by Eric Wong.
[#35746] Re: [Ruby 1.9 - Bug #4558] TestSocket#test_closed_read fails after r31230
— Eric Wong <normalperson@...>
2011/04/13
KOSAKI Motohiro <[email protected]> wrote:
[#35632] [Ruby 1.9 - Bug #4559][Open] Proc#== does not match the documented behaviour — Adam Prescott <redmine@...>
13 messages
2011/04/06
[#50251] [ruby-trunk - Bug #4559] Proc#== does not match the documented behaviour
— "matz (Yukihiro Matsumoto)" <matz@...>
2012/11/28
[#50252] Re: [ruby-trunk - Bug #4559] Proc#== does not match the documented behaviour
— SASADA Koichi <ko1@...>
2012/11/28
(2012/11/28 16:10), matz (Yukihiro Matsumoto) wrote:
[#50505] Re: [ruby-trunk - Bug #4559] Proc#== does not match the documented behaviour
— Charles Oliver Nutter <headius@...>
2012/12/03
I believe this will be a spec change, albeit a small one. Can we
[#35636] [Ruby 1.9 - Feature #4560][Open] [PATCH] lib/net/protocol.rb: avoid exceptions in rbuf_fill — Eric Wong <redmine@...>
6 messages
2011/04/07
[#35637] [Ruby 1.9 - Bug #4561][Open] 1.9.2 requires parentheses around argument of method call in an array, where 1.8.7 did not — Dave Schweisguth <redmine@...>
9 messages
2011/04/07
[#35644] [Ruby 1.8 - Bug #4563][Open] Dir#tell broken — Daniel Berger <redmine@...>
6 messages
2011/04/07
[#35648] mvm branch status? — Eric Wong <normalperson@...>
Hello, I noticed the "mvm" branch in SVN hasn't been updated in over a year.
10 messages
2011/04/07
[#35649] Re: mvm branch status?
— Urabe Shyouhei <shyouhei@...>
2011/04/07
Hi Eric.
[#35650] Re: mvm branch status?
— Evan Phoenix <evan@...>
2011/04/07
Has there been any thought on solving the C extension problem in MVM? In the present state, I've stopped working on it in Rubinius because there is no workable solution if there are C extensions in the mix.
[#35652] Re: mvm branch status?
— Eric Wong <normalperson@...>
2011/04/07
Evan Phoenix <[email protected]> wrote:
[#35691] Re: mvm branch status?
— Charles Oliver Nutter <headius@...>
2011/04/10
On Thu, Apr 7, 2011 at 6:18 PM, Eric Wong <[email protected]> wrote:
[#35666] caching of the ancestor chain — Xavier Noria <fxn@...>
Why does Ruby cache the ancestors chain? I mean, not why the implementation i=
9 messages
2011/04/09
[#35667] Re: caching of the ancestor chain
— Xavier Noria <fxn@...>
2011/04/09
Ah, in case it is not clear, where I find the metaphor broken is in that you=
[#35668] Re: caching of the ancestor chain
— Yukihiro Matsumoto <matz@...>
2011/04/09
Hi,
[#35692] Re: caching of the ancestor chain
— Charles Oliver Nutter <headius@...>
2011/04/10
On Fri, Apr 8, 2011 at 7:56 PM, Yukihiro Matsumoto <[email protected]> wro=
[#35678] [Ruby 1.9 - Bug #4564][Open] mingw-w64, truncate, ftruncate and ftello -- properly evalute it's existence — Luis Lavena <redmine@...>
8 messages
2011/04/09
[#35699] [Ruby 1.9 - Feature #4568][Open] [PATCH] file.c (rb_group_member): kill 256K of stack usage — redmine@...
4 messages
2011/04/11
[#35707] [Ruby 1.9 - Feature #4569][Open] Replace IPAddr with IPAddress — redmine@...
13 messages
2011/04/11
[#35713] [Ruby 1.9 - Bug #4571][Open] YAML.load given an ISO8601 timestamp creates an incorrect value for usec — redmine@...
5 messages
2011/04/11
[#35734] [Ruby 1.9 - Feature #4574][Open] Numeric#within — redmine@...
16 messages
2011/04/13
[#35753] [Ruby 1.9 - Bug #4576][Open] Range#step miss the last value, if end-exclusive and has float number — redmine@...
61 messages
2011/04/14
[#39198] [Ruby 1.9 - Bug #4576] Range#step miss the last value, if end-exclusive and has float number
— Vit Ondruch <v.ondruch@...>
2011/08/30
[#39508] Re: [Ruby 1.9 - Bug #4576] Range#step miss the last value, if end-exclusive and has float number
— V咜 Ondruch <v.ondruch@...>
2011/09/13
Can somebody please reopen this issue? Since the test suite fix is
[#39510] [Ruby 1.9 - Bug #4576] Range#step miss the last value, if end-exclusive and has float number
— Vit Ondruch <v.ondruch@...>
2011/09/13
[#39566] [Ruby 1.9 - Bug #4576] Range#step miss the last value, if end-exclusive and has float number
— Marc-Andre Lafortune <ruby-core@...>
2011/09/15
[#39582] Re: [Ruby 1.9 - Bug #4576] Range#step miss the last value, if end-exclusive and has float number
— Tanaka Akira <akr@...>
2011/09/16
2011/9/16 Marc-Andre Lafortune <[email protected]>:
[#39584] Re: [Ruby 1.9 - Bug #4576] Range#step miss the last value, if end-exclusive and has float number
— Michal Suchanek <hramrach@...>
2011/09/16
On 16 September 2011 15:49, Tanaka Akira <[email protected]> wrote:
[#39567] Re: [Ruby 1.9 - Bug #4576] Range#step miss the last value, if end-exclusive and has float number
— Kenta Murata <muraken@...>
2011/09/16
Hi,
[#39569] Re: [Ruby 1.9 - Bug #4576] Range#step miss the last value, if end-exclusive and has float number
— "NARUSE, Yui" <naruse@...>
2011/09/16
2011/9/16 Kenta Murata <[email protected]>:
[#39590] [Ruby 1.9 - Bug #4576] Range#step miss the last value, if end-exclusive and has float number
— Marc-Andre Lafortune <ruby-core@...>
2011/09/16
[#39593] Re: [Ruby 1.9 - Bug #4576] Range#step miss the last value, if end-exclusive and has float number
— Tanaka Akira <akr@...>
2011/09/16
2011/9/17 Marc-Andre Lafortune <[email protected]>:
[#39595] Re: [Ruby 1.9 - Bug #4576] Range#step miss the last value, if end-exclusive and has float number
— Tanaka Akira <akr@...>
2011/09/17
2011/9/17 Tanaka Akira <[email protected]>:
[#39604] Re: [Ruby 1.9 - Bug #4576] Range#step miss the last value, if end-exclusive and has float number
— "NARUSE, Yui" <naruse@...>
2011/09/17
(2011/09/17 9:07), Tanaka Akira wrote:
[#39608] Re: [Ruby 1.9 - Bug #4576] Range#step miss the last value, if end-exclusive and has float number
— Masahiro TANAKA <masa16.tanaka@...>
2011/09/17
I have not been watching ruby-core, but let me give a comment for this issu=
[#39637] Re: [Ruby 1.9 - Bug #4576] Range#step miss the last value, if end-exclusive and has float number
— Tanaka Akira <akr@...>
2011/09/20
2011/9/17 Masahiro TANAKA <[email protected]>:
[#39655] Re: [Ruby 1.9 - Bug #4576] Range#step miss the last value, if end-exclusive and has float number
— Masahiro TANAKA <masa16.tanaka@...>
2011/09/21
2011/9/20 Tanaka Akira <[email protected]>:
[#39656] Re: [Ruby 1.9 - Bug #4576] Range#step miss the last value, if end-exclusive and has float number
— masa <masa16.tanaka@...>
2011/09/21
I haven't explained the reason of the error estimation in
[#39657] Re: [Ruby 1.9 - Bug #4576] Range#step miss the last value, if end-exclusive and has float number
— Michal Suchanek <hramrach@...>
2011/09/21
On 21 September 2011 14:25, masa <[email protected]> wrote:
[#35754] [Ruby 1.9 - Bug #4577][Open] (int...float).max should not raise an error — redmine@...
8 messages
2011/04/14
[#35759] [Ruby 1.8 - Bug #4578][Open] Fixnum.freeze not frozen? — redmine@...
6 messages
2011/04/14
[#35765] [Ruby 1.9 - Bug #4579][Open] SecureRandom + OpenSSL may repeat with fork — redmine@...
27 messages
2011/04/15
[#35769] [Ruby 1.9 - Bug #4579] SecureRandom + OpenSSL may repeat with fork
— redmine@...
2011/04/15
[#35771] [Ruby 1.9 - Bug #4579] SecureRandom + OpenSSL may repeat with fork
— redmine@...
2011/04/15
[#35773] [Ruby 1.9 - Bug #4579] SecureRandom + OpenSSL may repeat with fork
— redmine@...
2011/04/15
[#35774] [Ruby 1.9 - Bug #4579] SecureRandom + OpenSSL may repeat with fork
— redmine@...
2011/04/15
[#35779] [Ruby 1.9 - Bug #4579] SecureRandom + OpenSSL may repeat with fork
— redmine@...
2011/04/15
[#35780] [Ruby 1.9 - Bug #4579] SecureRandom + OpenSSL may repeat with fork
— redmine@...
2011/04/15
[#35822] [Ruby 1.9 - Bug #4579] SecureRandom + OpenSSL may repeat with fork
— redmine@...
2011/04/20
[#35777] hashes are not consistent across ruby processes? — Roger Pack <rogerdpack2@...>
Hello all.
5 messages
2011/04/15
[#35813] [Ruby 1.9 - Bug #4320] Bus Error in digest/sha2 on sparc — redmine@...
1 message
2011/04/19
[#35814] [Ruby 1.9 - Bug #4320] Bus Error in digest/sha2 on sparc — redmine@...
1 message
2011/04/19
[#35825] [Ruby 1.8 - Bug #4587][Open] RMATCH_REGS definition is wrong — redmine@...
4 messages
2011/04/20
[#35828] [Ruby 1.9 - Feature #4589][Open] add Queue#each() method and include Enumerable — redmine@...
10 messages
2011/04/20
[#35830] [Ruby 1.9 - Feature #3436] Spawn the timer thread lazily — redmine@...
1 message
2011/04/20
[#35850] [Ruby 1.9 - Feature #4189] FileUtils#ln_r — Sakuro OZAWA <redmine@...>
1 message
2011/04/22
[#35866] [Ruby 1.9 - Bug #4603][Open] lib/csv.rb: when the :encoding parameter is not provided, the encoding of CSV data is treated as ASCII-8BIT — yu nobuoka <nobuoka@...>
13 messages
2011/04/24
[#35873] Re: [Ruby 1.9 - Bug #4603][Open] lib/csv.rb: when the :encoding parameter is not provided, the encoding of CSV data is treated as ASCII-8BIT
— James Gray <james@...>
2011/04/25
On Sun, Apr 24, 2011 at 1:33 AM, yu nobuoka <[email protected]>wrote:
[#35875] Re: [Ruby 1.9 - Bug #4603][Open] lib/csv.rb: when the :encoding parameter is not provided, the encoding of CSV data is treated as ASCII-8BIT
— "NARUSE, Yui" <naruse@...>
2011/04/25
2011/4/25 James Gray <[email protected]>:
[#35878] Re: [Ruby 1.9 - Bug #4603][Open] lib/csv.rb: when the :encoding parameter is not provided, the encoding of CSV data is treated as ASCII-8BIT
— James Gray <james@...>
2011/04/25
On Sun, Apr 24, 2011 at 11:29 PM, NARUSE, Yui <[email protected]> wrote:
[#35879] [Ruby 1.9 - Bug #4610][Open] Proc#curry behavior is inconsistent with lambdas containing default argument values — Joshua Ballanco <jballanc@...>
11 messages
2011/04/25
[#35892] [Ruby 1.9 - Feature #4610] Proc#curry behavior is inconsistent with lambdas containing default argument values
— Joshua Ballanco <jballanc@...>
2011/04/25
[#35883] [Ruby 1.9 - Bug #4611][Open] [BUG] Segementation fault reported — Deryl Doucette <me@...>
15 messages
2011/04/25
[#35895] [Ruby 1.9 - Feature #4614][Open] [RFC/PATCH] thread_pthread.c: lower RUBY_STACK_MIN_LIMIT to 64K — Eric Wong <normalperson@...>
10 messages
2011/04/25
[#35923] [Ruby 1.9 - Feature #4621][Open] NilClass#to_hash — Tsuyoshi Sawada <sawadatsuyoshi@...>
4 messages
2011/04/27
[#35933] [Ruby 1.9 - Bug #4623][Open] Consistent crash related to action_mailer — Alex Neth <alex@...>
7 messages
2011/04/27
[#35943] [Ruby 1.9 - Feature #3905] rb_clear_cache_by_class() called often during GC for non-blocking I/O — Motohiro KOSAKI <kosaki.motohiro@...>
3 messages
2011/04/29
[ruby-core:35907] Re: [Ruby 1.9 - Bug #4603][Open] lib/csv.rb: when the :encoding parameter is not provided, the encoding of CSV data is treated as ASCII-8BIT
From:
Nobuyoshi Nakada <nobu@...>
Date:
2011-04-26 16:27:02 UTC
List:
ruby-core #35907
Hi,
At Mon, 25 Apr 2011 22:57:52 +0900,
James Gray wrote in [ruby-core:35878]:
> The issue is that a mode of "rb" is being used to suppress newline
> translation on Windows. However, that's also switching my Encoding to
> ASCII-8BIT. Usually I love that feature, but here it's not what I want. Is
> there anyway to shut off the translation and not get the encoding change?
Now fixed so that universal_newline: false can work. What's
about the following patch?
diff --git i/lib/csv.rb w/lib/csv.rb
index 1aad2f3..d51cb55 100644
--- i/lib/csv.rb
+++ w/lib/csv.rb
@@ -1334,10 +1334,18 @@ class CSV
def self.open(*args)
# find the +options+ Hash
options = if args.last.is_a? Hash then args.pop else Hash.new end
- # default to a binary open mode
- args << "rb" if args.size == 1 and !options.key?(:mode)
- # wrap a File opened with the remaining +args+
- csv = new(File.open(*args, options), options)
+ # wrap a File opened with the remaining +args+ with no newline
+ # decorator
+ file_opts = {universal_newline: false}.merge(options)
+ begin
+ f = File.open(*args, file_opts)
+ rescue ArgumentError => e
+ throw unless /needs binmode/ =~ e.message and args.size == 1
+ args << "rb"
+ file_opts = {encoding: Encoding.default_external}.merge(file_opts)
+ retry
+ end
+ csv = new(f, options)
# handle blocks like Ruby's open(), not like the CSV library
if block_given?
@@ -1398,11 +1406,8 @@ class CSV
# <tt>encoding: "UTF-32BE:UTF-8"</tt> would read UTF-32BE data from the file
# but transcode it to UTF-8 before CSV parses it.
#
- def self.read(path, options = Hash.new)
- encoding = options.delete(:encoding)
- mode = "rb"
- mode << ":#{encoding}" if encoding
- open(path, mode, options) { |csv| csv.read }
+ def self.read(path, *options)
+ open(path, *options) { |csv| csv.read }
end
# Alias for CSV::read().
diff --git i/test/csv/test_encodings.rb w/test/csv/test_encodings.rb
index 3880f3a..54c34f3 100755
--- i/test/csv/test_encodings.rb
+++ w/test/csv/test_encodings.rb
@@ -79,6 +79,21 @@ class TestCSV::Encodings < TestCSV
end
end
+ def test_read_with_default_encoding
+ data = "abc"
+ default_external = Encoding.default_external
+ each_encoding do |encoding|
+ File.open(@temp_csv_path, "wb", encoding: encoding) {|f| f << data}
+ begin
+ Encoding.default_external = encoding
+ result = CSV.read(@temp_csv_path)[0][0]
+ ensure
+ Encoding.default_external = default_external
+ end
+ assert_equal(encoding, result.encoding)
+ end
+ end
+
#######################################################################
### Stress Test ASCII Compatible and Non-ASCII Compatible Encodings ###
#######################################################################
--
Nobu Nakada