[ruby-core:99497] [Ruby master Feature#17104] Do not freeze interpolated strings when using frozen-string-literal
From:
eregontp@...
Date:
2020-08-06 10:12:20 UTC
List:
ruby-core #99497
Issue #17104 has been updated by Eregon (Benoit Daloze).
byroot (Jean Boussier) wrote in #note-8:
> Because I understand the consistency argument. "All string literals are frozen" is much easier to wrap your head around than "All string literals are frozen except the ones that are interpolated".
I'd argue `"a#{2}c"` is not a string literal (`"a2c"` is a string literal).
It's actually syntactic sugar for `mutableEmptyStringOfSourceEncoding << "a" << 2.to_s << "c"`.
(+ `.freeze` everything in current semantics which feels unneeded)
Same as `42` is an integer literal, but `41 + 1` is not an integer literal.
----------------------------------------
Feature #17104: Do not freeze interpolated strings when using frozen-string-literal
https://bugs.ruby-lang.org/issues/17104#change-86955
* Author: bughit (bug hit)
* Status: Open
* Priority: Normal
----------------------------------------
```rb
#frozen_string_literal: true
def foo(str)
"#{str}"
end
fr1 = 'a'
fr2 = 'a'
fr1_1 = foo(fr1)
fr2_1 = foo(fr2)
puts fr1.__id__, fr2.__id__, fr1_1.__id__, fr2_1.__id__
puts fr1_1 << 'b'
```
Isn't the point of frozen literals to avoid needless allocations? But interpolated strings are allocated each time, so freezing appears pointless.
--
https://bugs.ruby-lang.org/
Unsubscribe: <mailto:[email protected]?subject=unsubscribe>
<http://lists.ruby-lang.org/cgi-bin/mailman/options/ruby-core>