[ruby-core:99781] [Ruby master Feature#17135] Improve performance of Integer#size method
From:
shyouhei@...
Date:
2020-08-31 01:15:27 UTC
List:
ruby-core #99781
Issue #17135 has been updated by shyouhei (Shyouhei Urabe).
Assignee set to ko1 (Koichi Sasada)
Status changed from Open to Assigned
The patch looks good to me. HOWEVER, let me -1 this.
Integer#size HAS to be as fast as what is proposed here, without any extra hustle like this.
@ko1 any idea what is preventing it from running smoothly?
----------------------------------------
Feature #17135: Improve performance of Integer#size method
https://bugs.ruby-lang.org/issues/17135#change-87298
* Author: S_H_ (Shun Hiraoka)
* Status: Assigned
* Priority: Normal
* Assignee: ko1 (Koichi Sasada)
----------------------------------------
`Integer#size` seems to show improved performance when written in ruby.
benchmark:
```yml
prelude: |
n = 42
benchmark:
size: |
n.size
loop_count: 20000000
```
result:
```bash
sh@MyComputer:~/rubydev/build$ make benchmark/integer_size.yml -e COMPARE_RUBY=~/.rbenv/shims/ruby -e BENCH_RUBY=../install/bin/ruby
# Iteration per second (i/s)
| |compare-ruby|built-ruby|
|:-----|-----------:|---------:|
|size | 65.749M| 87.117M|
| | -| 1.33x|
```
`COMPARE_RUBY` is `ruby 2.8.0dev (2020-08-28T10:47:29Z master 7e1fddba4a) [x86_64-linux]`. `BENCH_RUBY` is patched.
pull request:
https://github.com/ruby/ruby/pull/3476
--
https://bugs.ruby-lang.org/
Unsubscribe: <mailto:[email protected]?subject=unsubscribe>
<http://lists.ruby-lang.org/cgi-bin/mailman/options/ruby-core>