[ruby-core:99805] [Ruby master Bug#15313] [PATCH] Let debuggers know when a tail call happens
From:
merch-redmine@...
Date:
2020-08-31 20:17:08 UTC
List:
ruby-core #99805
Issue #15313 has been updated by jeremyevans0 (Jeremy Evans).
Status changed from Open to Closed
As tailcall optimization was removed in commit:241dced625f9ba8a4071954579778a0940e75179, I think this can be closed.
----------------------------------------
Bug #15313: [PATCH] Let debuggers know when a tail call happens
https://bugs.ruby-lang.org/issues/15313#change-87324
* Author: alanwu (Alan Wu)
* Status: Closed
* Priority: Normal
* Assignee: ko1 (Koichi Sasada)
* Backport: 2.3: UNKNOWN, 2.4: UNKNOWN, 2.5: UNKNOWN
----------------------------------------
## Background
The popular debugger "byebug" relies on tracepoint events to implement a few core functionality such as "next".
The "next" command needs to pause execution when the VM reaches the next line on the same stack frame. As there is no direct way, using the public
API, to tell the execution progress of a frame, Byebug keeps track of the currently executing frame by maintaining a counter using the "call" and "return"
tracepoint event. https://github.com/deivid-rodriguez/byebug/blob/58ee5114aa856ec49483532a86fd159a877dd6ab/ext/byebug/byebug.c#L162-L170
Byebug's counter becomes incorrect when the interpreter performs a tail call, since after a tail call, the "return" event doesn't fire for the caller. #15303
This causes the "next" command to misbehave when stepping over code that performs tail call. https://github.com/deivid-rodriguez/byebug/issues/481
## Proposed solution
I implemented a new method in TracePoint that lets Byebug, or any other debugger to differentiate between a normal method call and a tail call. Using this API,
Byebug can maintain the counter properly in the event of a tail call.
Here are some other solutions
- Some sort of public api that exposes execution progress of control frames. This might take a lot of effort.
- Some sort of public api that give ids to stack frames. After a tail call, debuggers can use this to tell that a frame is different, even though it's on the same location on the stack.
- Turning off tail call optimization in Forwardable. This side steps the problem but the core issue still remain. Third party libraries could still use tco
and byebug wouldn't be able to work with them.
Here are some downsides to my solution:
- This is a pretty niche feature that only debuggers want
- I'm adding a vm frame flag. While we have a few more bits to play with, it is a limited resource.
---Files--------------------------------
0001-Add-a-tail-call-predicate-for-TracePoint.patch (18.1 KB)
--
https://bugs.ruby-lang.org/
Unsubscribe: <mailto:[email protected]?subject=unsubscribe>
<http://lists.ruby-lang.org/cgi-bin/mailman/options/ruby-core>